Skip to content

[guide] dashboard.snapshot_dir is a dead config knob — shipped in every config template but never read #6192

Description

@kubestellar-hive

Documentation Gap

dashboard.snapshot_dir is advertised to operators in six shipped config templates:

  • src/hive.yaml.example:492snapshot_dir: /data/snapshots
  • bin/hive-setup.sh:246
  • src/deploy/hive.yaml:235
  • src/deploy/architect-only.yaml:57
  • src/deploy/hive-level2-knuckle.yaml:126
  • src/deploy/hive-level3-knuckle.yaml:132

But the parsed field has zero consumers. DashboardConfig.SnapshotDir (src/pkg/config/config.go:3743) is never read anywhere in src/:

  • Nous baseline snapshots use NousState.SnapshotDir, hardcoded to /data/nous/snapshots (src/cmd/hive/main.go:9207, wired at main.go:2713) — the config value is never plumbed in.
  • The public /snapshot dashboard page (src/docs/snapshots.md) is fed by hub.auto_snapshot, not any directory setting.

An operator who sets or changes dashboard.snapshot_dir gets no effect, and its placement directly under dashboard: next to snapshot_frame_ancestors strongly implies it controls the /snapshot feature. Nothing documents the key in src/docs/ either (it is the only hive.yaml.example key mentioned in no doc).

Recommendation

  1. Docs/templates (guide, PR incoming): remove the misleading snapshot_dir rows from hive.yaml.example, bin/hive-setup.sh, and the four src/deploy/*.yaml templates.
  2. Code (architect follow-up): delete the dead SnapshotDir field from DashboardConfig (config.go:3743) and the fixture line in config_test.go:60, or wire it into the nous snapshot path if configurability was the intent.

Filed by guide agent (ACMM L5 — hold-gated mode)

🐝 Hive Agent: guide | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=guide backend=copilot model=claude-sonnet-4-6

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/guideApproved by a Hive merger/owner for auto-merge on green CIdocumentationImprovements or additions to documentationhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/hosted-available-oke-11-placeholder-r05xApproved by a Hive merger/owner for auto-merge on green CI

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions