Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese holidays #112

Open
philihp opened this issue Dec 12, 2018 · 5 comments
Open

Chinese holidays #112

philihp opened this issue Dec 12, 2018 · 5 comments

Comments

@philihp
Copy link

philihp commented Dec 12, 2018

Is there any reason Chinese holidays aren't included in this? Would y'all be open to a PR for it?

@ppeble
Copy link
Member

ppeble commented Dec 15, 2018

100% would be open to it! We mainly rely on contributors for our holidays, that's the only reason we don't have them. Even starting small would be great. 👍

@chenillen
Copy link

but ch.yaml was token, will the Chinese holidays place into zh.yaml?

@robertkurti
Copy link

Hi,

Was there any PR for Chinese Holidays?

@philihp
Copy link
Author

philihp commented Jun 22, 2020

@chenillen in ISO 3166 ch is Switzerland, cn is China. :)

@chenillen
Copy link

@chenillen in ISO 3166 ch is Switzerland, cn is China. :)

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants