Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update make validate so that it ensures that definition is present in index.yaml #4

Open
ppeble opened this issue Sep 24, 2016 · 1 comment

Comments

@ppeble
Copy link
Member

ppeble commented Sep 24, 2016

The make validate target should raise an error if a definition is not present in index.yaml. We can do this by loading the index config file and then doing a simple check based on the input symbol (i.e. :hk should be present in index.yaml.

@ppeble ppeble self-assigned this Sep 24, 2016
@ppeble
Copy link
Member Author

ppeble commented Jul 3, 2017

Additional checks:

We currently allow incorrect naming of the files in our index.yaml file. We should require the following:

  1. We should have a matching file in the repo, meaning if we put 'us.yaml' then that file must exist.
  2. We should enforce '.yaml'. Right now we will allow anything.

@ppeble ppeble removed their assignment Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant