Skip to content

Commit 225aebe

Browse files
clean up in GroupsAsCats (#1803)
1 parent 1ae3e09 commit 225aebe

File tree

5 files changed

+141
-117
lines changed

5 files changed

+141
-117
lines changed

CAP/PackageInfo.g

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ SetPackageInfo( rec(
1010

1111
PackageName := "CAP",
1212
Subtitle := "Categories, Algorithms, Programming",
13-
Version := "2025.11-01",
13+
Version := "2025.11-02",
1414
Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
1515
License := "GPL-2.0-or-later",
1616

CAP/gap/CategoriesCategory.gi

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -633,11 +633,9 @@ AddHorizontalPreCompose( category,
633633
function( cat, left_natural_transformation, right_natural_transformation )
634634
local pre_compose_transfo_functor, pre_compose_functor_transfo;
635635

636-
pre_compose_transfo_functor :=
637-
HorizontalPreComposeNaturalTransformationWithFunctor( left_natural_transformation, Source( right_natural_transformation ) );
636+
pre_compose_transfo_functor := HorizontalPreComposeNaturalTransformationWithFunctor( left_natural_transformation, Source( right_natural_transformation ) );
638637

639-
pre_compose_functor_transfo :=
640-
HorizontalPreComposeFunctorWithNaturalTransformation( Range( left_natural_transformation ), right_natural_transformation );
638+
pre_compose_functor_transfo := HorizontalPreComposeFunctorWithNaturalTransformation( Range( left_natural_transformation ), right_natural_transformation );
641639

642640
return VerticalPreCompose( pre_compose_transfo_functor, pre_compose_functor_transfo );
643641

CAP/gap/DerivedMethods.gi

Lines changed: 17 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -2608,18 +2608,14 @@ AddDerivationToCAP( BasisOfSolutionsOfHomogeneousLinearSystemInLinearCategory,
26082608

26092609
return List( basis, m ->
26102610
List( [ 1 .. n ], j ->
2611-
InterpretMorphismFromDistinguishedObjectToHomomorphismStructureAsMorphism( cat,
2612-
Target( left_coefficients[1][j] ),
2613-
Source( right_coefficients[1][j] ),
2614-
PreCompose( range_cat, m, ProjectionInFactorOfDirectSum( range_cat, H_B_C, j ) )
2615-
)
2616-
)
2617-
);
2611+
InterpretMorphismFromDistinguishedObjectToHomomorphismStructureAsMorphism( cat,
2612+
Target( left_coefficients[1][j] ),
2613+
Source( right_coefficients[1][j] ),
2614+
PreCompose( range_cat, m, ProjectionInFactorOfDirectSum( range_cat, H_B_C, j ) ) ) ) );
26182615

26192616
end :
26202617
CategoryGetters := rec( range_cat := RangeCategoryOfHomomorphismStructure ),
2621-
CategoryFilter := cat -> HasIsLinearCategoryOverCommutativeRing( cat ) and IsLinearCategoryOverCommutativeRing( cat ) and HasRangeCategoryOfHomomorphismStructure( cat )
2622-
);
2618+
CategoryFilter := cat -> HasIsLinearCategoryOverCommutativeRing( cat ) and IsLinearCategoryOverCommutativeRing( cat ) and HasRangeCategoryOfHomomorphismStructure( cat ) );
26232619

26242620
##
26252621
AddDerivationToCAP( BasisOfSolutionsOfHomogeneousDoubleLinearSystemInLinearCategory,
@@ -2650,17 +2646,15 @@ AddDerivationToCAP( BasisOfSolutionsOfHomogeneousDoubleLinearSystemInLinearCateg
26502646

26512647
H_A_D := List( [ 1 .. m ], i -> HomomorphismStructureOnObjects( cat, Source( alpha[i][1] ), Target( beta[i][1] ) ) );
26522648

2653-
list_1 :=
2654-
List( [ 1 .. n ],
2655-
j -> List( [ 1 .. m ], i -> HomomorphismStructureOnMorphisms( cat, alpha[i][j], beta[i][j] ) )
2656-
);
2649+
list_1 := List( [ 1 .. n ], j ->
2650+
List( [ 1 .. m ], i ->
2651+
HomomorphismStructureOnMorphisms( cat, alpha[i][j], beta[i][j] ) ) );
26572652

26582653
H_1 := MorphismBetweenDirectSums( range_cat, H_B_C, list_1, H_A_D );
26592654

2660-
list_2 :=
2661-
List( [ 1 .. n ],
2662-
j -> List( [ 1 .. m ], i -> HomomorphismStructureOnMorphisms( cat, gamma[i][j], delta[i][j] ) )
2663-
);
2655+
list_2 := List( [ 1 .. n ], j ->
2656+
List( [ 1 .. m ], i ->
2657+
HomomorphismStructureOnMorphisms( cat, gamma[i][j], delta[i][j] ) ) );
26642658

26652659
H_2 := MorphismBetweenDirectSums( range_cat, H_B_C, list_2, H_A_D );
26662660

@@ -2671,19 +2665,15 @@ AddDerivationToCAP( BasisOfSolutionsOfHomogeneousDoubleLinearSystemInLinearCateg
26712665
B := List( B, m -> PreCompose( range_cat, m, iota ) );
26722666

26732667
return List( B, m ->
2674-
List( [ 1 .. n ], j ->
2675-
InterpretMorphismFromDistinguishedObjectToHomomorphismStructureAsMorphism( cat,
2676-
Target( alpha[1][j] ),
2677-
Source( beta[1][j] ),
2678-
PreCompose( range_cat, m, ProjectionInFactorOfDirectSum( range_cat, H_B_C, j ) )
2679-
)
2680-
)
2681-
);
2668+
List( [ 1 .. n ], j ->
2669+
InterpretMorphismFromDistinguishedObjectToHomomorphismStructureAsMorphism( cat,
2670+
Target( alpha[1][j] ),
2671+
Source( beta[1][j] ),
2672+
PreCompose( range_cat, m, ProjectionInFactorOfDirectSum( range_cat, H_B_C, j ) ) ) ) );
26822673

26832674
end :
26842675
CategoryGetters := rec( range_cat := RangeCategoryOfHomomorphismStructure ),
2685-
CategoryFilter := cat -> HasIsLinearCategoryOverCommutativeRing( cat ) and IsLinearCategoryOverCommutativeRing( cat ) and HasRangeCategoryOfHomomorphismStructure( cat )
2686-
);
2676+
CategoryFilter := cat -> HasIsLinearCategoryOverCommutativeRing( cat ) and IsLinearCategoryOverCommutativeRing( cat ) and HasRangeCategoryOfHomomorphismStructure( cat ) );
26872677

26882678
## Final methods for Equalizer
26892679

GroupsAsCategoriesForCAP/PackageInfo.g

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ SetPackageInfo( rec(
1010

1111
PackageName := "GroupsAsCategoriesForCAP",
1212
Subtitle := "Groups as categories on one object",
13-
Version := "2025.08-01",
13+
Version := "2025.11-01",
1414
Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
1515
License := "GPL-2.0-or-later",
1616

0 commit comments

Comments
 (0)