Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DE] person_HassGetState, "Ist Person zuhause" funktioniert nicht, nur "Ist Person home" #2952

Closed
amatthies opened this issue Feb 3, 2025 · 6 comments · Fixed by #2954
Closed

Comments

@amatthies
Copy link

Laut Test sentences de müsste "Ist Anne Zuhause" funktionieren, aber der state "Zuhause" wird nicht gefunden oder übersetzt:

Image Image Image

(HA Core Version: 2025.1.4, Assistant: Home Assistant Cloud)

@andreasbrett
Copy link
Contributor

andreasbrett commented Feb 3, 2025

@synesthesiam Since states are now raw instead of translated, there are now issues with HassGetState for person and the home zone (the only zone with a raw and translated state). If you're querying the whereabouts of a person in the home zone, in any language the zone will be home (not Zuhause, maison, ....). Easy to fix, language leaders can simply translate in the response. But... for querying if a person is at home this is also the case. It only works when asking for home (not Zuhause, maison, ....).

Image

Image

Image

Image
(no I'm not female, but my french is really bad...)

Image

Image

@tetele
Copy link
Contributor

tetele commented Feb 3, 2025

That's easily fixable with a "fixed" sentence like ist <name> zuhause where you set the zone slot to home

And another one for away

@andreasbrett
Copy link
Contributor

Yes, but...

a) all non-english languages will have to do this, so language leaders need to be made aware
b) we are once more in a situation where intents and lokalise can be out of sync at times

@tetele
Copy link
Contributor

tetele commented Feb 3, 2025

a) sure. let's get people involved!
b) that's been going on since forever and there's no easy fix. it's actually better for intents to redefine translations (based on lokalise) so as no breaking changes occur without modifications to intents

@amatthies
Copy link
Author

@andreasbrett Es gibt noch ein kleines Problem: "Ist Person zuhause" funktioniert jetzt (danke!), aber wenn man es nicht eintippt, sondern sagt, macht die Spracherkennung daraus korrekterweise "Ist Person zu Hause". Und das wird dann wieder nicht erkannt....

Image

@andreasbrett
Copy link
Contributor

Danke dir für das Feedback, ich baue die verschiedenen TTS Varianten für "zuhause" später ein.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants