Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account.signOut({ignoreLocalChanges: true}) #137

Open
gr2m opened this issue Feb 22, 2017 · 0 comments
Open

account.signOut({ignoreLocalChanges: true}) #137

gr2m opened this issue Feb 22, 2017 · 0 comments

Comments

@gr2m
Copy link
Member

gr2m commented Feb 22, 2017

There are valid use cases when we want to allow users to be able to clear all data in the browser without sending any requests to the server.

By default, we try to sync all local changes first, then send a request to invalidate the session. If either fails, account.signOut() rejects with a request or authorization header.

But

  • if user does not care about local changes and is currently offline and want to remove all their local data, we should allow to do that
  • The account might have been removed from the server and there is currently no built-in way to remove the data in the browser. This happens quite often for local development and is rather annoying

ignoreLocalChanges does not communicate that we don’t send a request at all, but I think it communicates pretty well the implication to the user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant