Skip to content

Commit 9e90e96

Browse files
authored
fix(metrics): map connection_id/connection-id to webhook_id for --dimensions (#224)
The API expects dimension name webhook_id (historical); agents and users often pass connection_id. Map connection_id and connection-id to webhook_id so 'hookdeck gateway metrics events ... --dimensions connection_id' works without 422. Also improve --dimensions help with example dimensions. Made-with: Cursor
1 parent 0066e7b commit 9e90e96

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

pkg/cmd/metrics.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ func addMetricsCommonFlagsEx(cmd *cobra.Command, f *metricsCommonFlags, skipIssu
7979
cmd.Flags().StringVar(&f.end, "end", "", "End of time range (ISO 8601 date-time, required)")
8080
cmd.Flags().StringVar(&f.granularity, "granularity", "", granularityHelp)
8181
cmd.Flags().StringVar(&f.measures, "measures", "", "Comma-separated list of measures to return")
82-
cmd.Flags().StringVar(&f.dimensions, "dimensions", "", "Comma-separated list of dimensions")
82+
cmd.Flags().StringVar(&f.dimensions, "dimensions", "", "Comma-separated dimensions to group by (e.g. connection_id, source_id, destination_id, status)")
8383
cmd.Flags().StringVar(&f.sourceID, "source-id", "", "Filter by source ID")
8484
cmd.Flags().StringVar(&f.destinationID, "destination-id", "", "Filter by destination ID")
8585
cmd.Flags().StringVar(&f.connectionID, "connection-id", "", "Filter by connection ID")
@@ -106,6 +106,10 @@ func metricsParamsFromFlags(f *metricsCommonFlags) hookdeck.MetricsQueryParams {
106106
if f.dimensions != "" {
107107
for _, s := range strings.Split(f.dimensions, ",") {
108108
if t := strings.TrimSpace(s); t != "" {
109+
// API expects webhook_id for connection dimension; CLI accepts connection_id/connection-id for consistency.
110+
if t == "connection_id" || t == "connection-id" {
111+
t = "webhook_id"
112+
}
109113
dimensions = append(dimensions, t)
110114
}
111115
}

0 commit comments

Comments
 (0)