Skip to content

Commit ec62347

Browse files
committed
chore(acceptance): run telemetry tests in slice 1, remove unreproducible test
- Tag telemetry_test.go with 'telemetry' (was 'connection'); run in slice 1 with request, event - CI and run_parallel.sh: add telemetry to slice 1 tags - Remove TestTelemetryThreeRequestsOneCommandPath (three-request bug not reproducible with current CLI) Made-with: Cursor
1 parent f67928c commit ec62347

4 files changed

Lines changed: 8 additions & 7 deletions

File tree

.github/workflows/test-acceptance.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
tags: "basic connection source destination gateway mcp listen project_use connection_list connection_upsert connection_error_hints connection_oauth_aws connection_update"
1818
- slice: "1"
1919
api_key_secret: HOOKDECK_CLI_TESTING_API_KEY_2
20-
tags: "request event"
20+
tags: "request event telemetry"
2121
- slice: "2"
2222
api_key_secret: HOOKDECK_CLI_TESTING_API_KEY_3
2323
tags: "attempt metrics issue transformation"

test/acceptance/README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ CI runs acceptance tests in **three parallel jobs**, each with its own API key (
5555
### Run all automated tests (one key)
5656
Pass all feature tags so every automated test file is included:
5757
```bash
58-
go test -tags="basic connection source destination gateway mcp listen project_use connection_list connection_upsert connection_error_hints connection_oauth_aws connection_update request event attempt metrics issue transformation" ./test/acceptance/... -v
58+
go test -tags="basic connection source destination gateway mcp listen project_use connection_list connection_upsert connection_error_hints connection_oauth_aws connection_update request event telemetry attempt metrics issue transformation" ./test/acceptance/... -v
5959
```
6060

6161
### Run one slice (for CI or local)
@@ -64,11 +64,12 @@ Same commands as CI; use when debugging a subset or running in parallel:
6464
# Slice 0 (same tags as CI job 0)
6565
ACCEPTANCE_SLICE=0 go test -tags="basic connection source destination gateway mcp listen project_use connection_list connection_upsert connection_error_hints connection_oauth_aws connection_update" ./test/acceptance/... -v -timeout 12m
6666

67-
# Slice 1 (same tags as CI job 1)
68-
ACCEPTANCE_SLICE=1 go test -tags="request event" ./test/acceptance/... -v -timeout 12m
67+
# Slice 1 (same tags as CI job 1: request, event, telemetry)
68+
ACCEPTANCE_SLICE=1 go test -tags="request event telemetry" ./test/acceptance/... -v -timeout 12m
6969

7070
# Slice 2 (same tags as CI job 2)
7171
ACCEPTANCE_SLICE=2 go test -tags="attempt metrics issue transformation" ./test/acceptance/... -v -timeout 12m
72+
7273
```
7374
For slice 1 set `HOOKDECK_CLI_TESTING_API_KEY_2`; for slice 2 set `HOOKDECK_CLI_TESTING_API_KEY_3` (or set `HOOKDECK_CLI_TESTING_API_KEY` to that key).
7475

@@ -102,7 +103,7 @@ Use the same `-tags` as "Run all" if you want to skip the full acceptance set. A
102103
Tests are partitioned by **feature build tags** so CI and local runs can execute three slices in parallel (each slice uses its own Hookdeck project and config file).
103104

104105
- **Slice 0 features:** `basic`, `connection`, `source`, `destination`, `gateway`, `mcp`, `listen`, `project_use`, `connection_list`, `connection_upsert`, `connection_error_hints`, `connection_oauth_aws`, `connection_update`
105-
- **Slice 1 features:** `request`, `event`
106+
- **Slice 1 features:** `request`, `event`, `telemetry`
106107
- **Slice 2 features:** `attempt`, `metrics`, `issue`, `transformation`
107108

108109
The CI workflow (`.github/workflows/test-acceptance.yml`) runs three jobs with the same `go test -tags="..."` commands and env (`ACCEPTANCE_SLICE`, API keys). No test names or regexes are listed in YAML.

test/acceptance/run_parallel.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ SLICE1_LOG="$LOG_DIR/slice1.log"
2626
SLICE2_LOG="$LOG_DIR/slice2.log"
2727

2828
SLICE0_TAGS="basic connection source destination gateway mcp listen project_use connection_list connection_upsert connection_error_hints connection_oauth_aws connection_update"
29-
SLICE1_TAGS="request event"
29+
SLICE1_TAGS="request event telemetry"
3030
SLICE2_TAGS="attempt metrics issue transformation"
3131

3232
run_slice0() {

test/acceptance/telemetry_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//go:build connection
1+
//go:build telemetry
22

33
package acceptance
44

0 commit comments

Comments
 (0)