Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexluong
changed the title
alexbouchardd
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Retry ID collision for multi-destination events
Problem
When a single event fans out to multiple destinations and all deliveries fail, only one retry was scheduled. The others were silently overwritten because
GetRetryID()returned onlyevent.ID, causing all retries to share the same scheduler task ID.Solution
Changed
GetRetryID()to returnevent.ID + ":" + destination.ID, making retry IDs unique per event+destination combination.We use this composite key (not
DeliveryEvent.ID) because manual retries create a new DeliveryEvent but must still be able to cancel pending automatic retries for the same event+destination.Tests
TestMessageHandler_RetryID_MultipleDestinations- verifies unique retry IDs for fan-outTestManualDelivery_Success- verifies manual retry cancels the correct pending retry