fix(python-sdk): remove poetry.lock, overlay dir→direction for pylint W0622#702
Merged
Merged
Conversation
… W0622 - Delete poetry.lock so CI regenerates it (avoids pydantic-core 2.33.2 without Python 3.14 wheels; Speakeasy repro confirmed this fixes venv/install). - Add pagination overlay: rename query param 'dir' to 'direction' on four list endpoints to avoid shadowing Python builtin dir() (pylint W0622). Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Improves Python SDK generation/CI reliability by removing the pinned Poetry lockfile (allowing dependency resolution to adapt to the CI Python version) and by overlay-renaming the dir query parameter to avoid Python builtin shadowing in generated SDK method signatures.
Changes:
- Delete
sdks/outpost-python/poetry.lockto avoid pinning transitive deps that may not have wheels for the CI Python version. - Add overlay actions to rename the
dirquery parameter todirectionon the four endpoints that expose it.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
sdks/schemas/pagination-fixes-overlay.yaml |
Adds x-speakeasy-name-override rules to rename dir → direction for Python SDK generation. |
sdks/outpost-python/poetry.lock |
Removes the Poetry lockfile so CI/generation can resolve compatible dependency versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses Python SDK CI compile failures (per Speakeasy feedback):
Delete
poetry.lock– The pinned pydantic-core (2.33.2) has no Python 3.14 wheels;poetry installwas failing when building from source. Removing the lock lets CI regenerate it with compatible versions.Pagination overlay:
dir→direction– The query paramdir(sort direction) was generated as a Python parameterdir, shadowing the builtin and causing pylint W0622. Overlay renames it todirectionon the four list endpoints (GET /tenants, /events, /attempts, /tenants/.../destinations/.../attempts).How to verify
After merge: run Generate OUTPOST-PYTHON workflow and confirm the compile step passes.
Made with Cursor