Skip to content

Commit 63d4bbb

Browse files
ezyangfacebook-github-bot
authored andcommitted
Turn XLA back on for default set (but filtered out using should_run_job) (pytorch#21470)
Summary: Pull Request resolved: pytorch#21470 ghimport-source-id: 69800c1 Differential Revision: D15696930 Pulled By: ezyang fbshipit-source-id: fafbcba38d9572a23ee9c1d81cdcce3a154ae4c6
1 parent f433913 commit 63d4bbb

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

.circleci/cimodel/data/pytorch_build_data.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
("5.4", [
1717
XImportant("3.6"),
1818
("3.6", [
19-
("xla", [X(True)]),
19+
("xla", [XImportant(True)]),
2020
("namedtensor", [X(True)]),
2121
]),
2222
]),
@@ -147,6 +147,9 @@ def modify_label(self, label):
147147
def init2(self, node_name):
148148
self.props["is_xla"] = node_name
149149

150+
def child_constructor(self):
151+
return ImportantConfigNode
152+
150153

151154
class NamedTensorConfigNode(TreeConfigNode):
152155
def modify_label(self, label):
@@ -163,6 +166,9 @@ def modify_label(self, label):
163166
def init2(self, node_name):
164167
self.props["is_important"] = node_name
165168

169+
def get_children(self):
170+
return []
171+
166172

167173
class XenialCompilerConfigNode(TreeConfigNode):
168174

.circleci/config.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2438,16 +2438,10 @@ workflows:
24382438
- pytorch_xla_linux_trusty_py3_6_gcc5_4_build:
24392439
requires:
24402440
- setup
2441-
filters:
2442-
branches:
2443-
only: master
24442441
- pytorch_xla_linux_trusty_py3_6_gcc5_4_test:
24452442
requires:
24462443
- setup
24472444
- pytorch_xla_linux_trusty_py3_6_gcc5_4_build
2448-
filters:
2449-
branches:
2450-
only: master
24512445
- pytorch_namedtensor_linux_trusty_py3_6_gcc5_4_build:
24522446
requires:
24532447
- setup

.circleci/scripts/should_run_job.sh

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
#!/usr/bin/env bash
22
set -exu -o pipefail
33

4-
echo "This check is currently disabled in favor of branch-based filtering"
5-
exit 0
6-
74
SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
85

96
# Check if we should actually run

0 commit comments

Comments
 (0)