Make PlatformColor extend NativeColorValue type (facebook#54436)

Summary:
Pull Request resolved: facebook#54436

## Changelog:

[Internal] [Changed] - Make PlatformColor extend NativeColorValue type

Currently PlatformColor extends ColorValue type which is union of null, number, string, NativeColorValue etc. But it's essentially a NativeColorValue (aka OpaqueColorValue) type on every platform. Here we're typing it more specifically.

Reviewed By: javache

Differential Revision: D86351282

fbshipit-source-id: 291fee34c97c7ac6ec496f6fcd8e794ee6088f58

Author: zeyap

packages/react-native/Libraries/StyleSheet/PlatformColorValueTypes.android.js

@@ -9,14 +9,14 @@
  */
 
 import type {ProcessedColorValue} from './processColor';
-import type {ColorValue, NativeColorValue} from './StyleSheet';
+import type {NativeColorValue} from './StyleSheet';
 
 /** The actual type of the opaque NativeColorValue on Android platform */
 type LocalNativeColorValue = {
   resource_paths?: Array<string>,
 };
 
-export const PlatformColor = (...names: Array<string>): ColorValue => {
+export const PlatformColor = (...names: Array<string>): NativeColorValue => {
   /* $FlowExpectedError[incompatible-type]
    * LocalNativeColorValue is the actual type of the opaque NativeColorValue on Android platform */
   return ({resource_paths: names}: LocalNativeColorValue);

packages/react-native/Libraries/StyleSheet/PlatformColorValueTypes.ios.js

@@ -22,7 +22,7 @@ type LocalNativeColorValue = {
   },
 };
 
-export const PlatformColor = (...names: Array<string>): ColorValue => {
+export const PlatformColor = (...names: Array<string>): NativeColorValue => {
   // $FlowExpectedError[incompatible-type] LocalNativeColorValue is the iOS LocalNativeColorValue type
   return ({semantic: names}: LocalNativeColorValue);
 };

packages/react-native/Libraries/StyleSheet/PlatformColorValueTypes.js.flow

@@ -9,9 +9,11 @@
  */
 
 import type {ProcessedColorValue} from './processColor';
-import type {ColorValue, NativeColorValue} from './StyleSheet';
+import type {NativeColorValue} from './StyleSheet';
 
-declare export function PlatformColor(...names: Array<string>): ColorValue;
+declare export function PlatformColor(
+  ...names: Array<string>
+): NativeColorValue;
 
 declare export function normalizeColorObject(
   color: NativeColorValue,

packages/react-native/ReactNativeApi.d.ts

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<a01aee11d06658fe06d702ee4c48bf8e>>
+ * @generated SignedSource<<1eb51bd683ea578d108218d5a48c42ec>>
  *
  * This file was generated by scripts/js-api/build-types/index.js.
  */
@@ -3669,7 +3669,7 @@ declare class PixelRatio {
   static startDetecting(): void
 }
 declare type Platform = typeof Platform
-declare function PlatformColor(...names: Array<string>): ColorValue
+declare function PlatformColor(...names: Array<string>): NativeColorValue
 declare type PlatformConfig = {}
 declare type PlatformOSType =
   | "android"
@@ -6080,7 +6080,7 @@ export {
   PermissionsAndroid, // 0c1619e7
   PixelRatio, // 10d9e32d
   Platform, // dc0f5740
-  PlatformColor, // be964947
+  PlatformColor, // 8297ec62
   PlatformOSType, // 0a17561e
   PlatformSelectSpec, // 09ed7758
   PointValue, // 69db075f