-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better name for the "expires" attribute in Upload-Limit #2940
Comments
Some possible inspiration maybe? https://www.ietf.org/archive/id/draft-ietf-httpapi-ratelimit-headers-08.html#section-3.1.3
|
Maybe we could use
Another idea could be
EDIT: On the other hand, these do not really convey the same thing. Upload-Limit -> Expires is the amount left before the upload expires while e.g. |
Another solution would be to change expires into a sf date: https://www.ietf.org/rfc/rfc9651.html#name-dates |
https://www.rfc-editor.org/rfc/rfc7838.html#section-3.1
ma = delta-seconds; see [RFC7234], Section 1.2.1 The delta-seconds value indicates the number of seconds since the |
When we first discussed the Upload-Limit, the WG argued that relative durations are preferable to absolute timestamps as durations also work if the client and server don't have aligned clocks. That makes sense, so I would vote for keeping the current value but choosing a different name. |
Personally, I think
are all good options. |
"Expires-In" doesn't have an intuitive meaning for me. My immediate thought was "What does it expire in? A bucket? The back of a fridge?" "Expires-After" perhaps. However, why come up with NIH terminology where there is already a clearly established pattern that says "max-age" is the validity duration of a thing. We use that for more than just |
Thank you for the input, Martin. Given that, it makes sense to reuse the terminology and I opened #3012 to change the name. |
Expires typically is an absolute timestamp, but it is a number of seconds in Upload-Limit. It might be better named as
timeout
or something similar.The text was updated successfully, but these errors were encountered: