a

Author: hu8813

c08/ex01/Span.cpp

@@ -37,13 +37,12 @@ int Span::shortestSpan() const {
     if (_numbers.size() < 2) {
         throw std::out_of_range("Span must contain at least 2 numbers");
     }
-    std::multiset<int> sortedNumbers(_numbers);
-    std::multiset<int>::iterator it = sortedNumbers.begin();
+    std::multiset<int>::iterator it = _numbers.begin();
     int shortest = std::abs(*it - *(++it));
-    if (it != sortedNumbers.end()) {
+    if (it != _numbers.end()) {
     std::multiset<int>::iterator next = it;
-    ++next; // Advance 'next' to the next element
-    while (next != sortedNumbers.end()) {
+    ++next;
+    while (next != _numbers.end()) {
         int diff = std::abs(*next - *it);
         if (diff < shortest) {
             shortest = diff;

c08/ex02/main.cpp

@@ -10,9 +10,11 @@ int main()
         mstack.push(5);
         mstack.push(17);
 
+        if (!mstack.empty())
+        {
         std::cout << "Top element: " << mstack.top() << std::endl;
-
         mstack.pop();
+        }
 
         std::cout << "Size: " << mstack.size() << std::endl;
 
@@ -38,9 +40,11 @@ int main()
         mstack.push_back(5);
         mstack.push_back(17);
 
+        if (!mstack.empty())
+        {
         std::cout << "Top element: " << mstack.back() << std::endl;
-
         mstack.pop_back();
+        }
 
         std::cout << "Size: " << mstack.size() << std::endl;
 
@@ -67,9 +71,11 @@ int main()
         mstack.push_back(5);
         mstack.push_back(17);
 
+        if (!mstack.empty())
+        {
         std::cout << "Top element: " << mstack.back() << std::endl;
-
         mstack.pop_back();
+        }
 
         std::cout << "Size: " << mstack.size() << std::endl;
 
@@ -96,9 +102,11 @@ int main()
         mstack.push_back(5);
         mstack.push_back(17);
 
+        if (!mstack.empty())
+        {
         std::cout << "Top element: " << mstack.back() << std::endl;
-
         mstack.pop_back();
+        }
 
         std::cout << "Size: " << mstack.size() << std::endl;