chore: fix check code quality

Author: frascuchon

src/datasets/features/midi.py

@@ -118,25 +118,17 @@ def _create_midi_from_data(cls, value: dict) -> "pretty_midi.PrettyMIDI":
         except ImportError as err:
             raise ImportError("To support encoding MIDI data, please install 'pretty_midi'.") from err
 
-
-
         # Create piano instrument
-        piano_program = pretty_midi.instrument_name_to_program('Acoustic Grand Piano')
+        piano_program = pretty_midi.instrument_name_to_program("Acoustic Grand Piano")
         piano = pretty_midi.Instrument(program=piano_program)
 
         notes = value.get("notes", [])
         for note_data in notes:
             if len(note_data) >= 4:
                 pitch, velocity, start, end = note_data[:4]
-                note = pretty_midi.Note(
-                    velocity=int(velocity),
-                    pitch=int(pitch),
-                    start=float(start),
-                    end=float(end)
-                )
+                note = pretty_midi.Note(velocity=int(velocity), pitch=int(pitch), start=float(start), end=float(end))
                 piano.notes.append(note)
 
-
         if "tempo" in value:
             midi = pretty_midi.PrettyMIDI(initial_tempo=value["tempo"])
         else:
@@ -208,10 +200,9 @@ def decode_example(
         # Extract instrument information
         instruments = []
         for instrument in midi.instruments:
-            instruments.append({
-                "program": instrument.program,
-                "name": pretty_midi.program_to_instrument_name(instrument.program)
-            })
+            instruments.append(
+                {"program": instrument.program, "name": pretty_midi.program_to_instrument_name(instrument.program)}
+            )
 
         # Get tempo
         tempo = 120.0  # Default tempo

tests/features/test_midi.py

@@ -1,12 +1,9 @@
-import os
-import tempfile
 from unittest import TestCase
 
-import numpy as np
 import pytest
 
-from datasets import Dataset, Features, load_dataset
-from datasets.features import Midi, Value
+from datasets import Dataset, Features
+from datasets.features import Midi
 
 
 class TestMidiFeature(TestCase):
@@ -17,30 +14,26 @@ def test_audio_feature_type(self):
 
     def test_audio_feature_encode_example(self):
         midi = Midi()
-        
+
         # Test with path
         encoded = midi.encode_example("path/to/midi.mid")
         assert encoded == {"bytes": None, "path": "path/to/midi.mid"}
-        
+
         # Test with bytes
         encoded = midi.encode_example(b"fake_midi_bytes")
         assert encoded == {"bytes": b"fake_midi_bytes", "path": None}
-        
+
         # Test with dict containing notes
-        notes_data = {
-            "notes": [[60, 64, 0.0, 1.0], [62, 64, 1.0, 2.0]],
-            "tempo": 120.0,
-            "resolution": 480
-        }
+        notes_data = {"notes": [[60, 64, 0.0, 1.0], [62, 64, 1.0, 2.0]], "tempo": 120.0, "resolution": 480}
         encoded = midi.encode_example(notes_data)
         assert "bytes" in encoded
         assert encoded["path"] is None
 
     def test_audio_feature_decode_example(self):
         midi = Midi()
-        
+
         # Test decode with bytes
-        fake_midi_bytes = b'MThd\x00\x00\x00\x06\x00\x01\x00\x02\x00\xdcMTrk\x00\x00\x00\x13\x00\xffQ\x03\x07\xa1 \x00\xffX\x04\x04\x02\x18\x08\x01\xff/\x00MTrk\x00\x00\x00\x16\x00\xc0\x00\x00\x90<@\x838<\x00\x00>@\x838>\x00\x01\xff/\x00'
+        fake_midi_bytes = b"MThd\x00\x00\x00\x06\x00\x01\x00\x02\x00\xdcMTrk\x00\x00\x00\x13\x00\xffQ\x03\x07\xa1 \x00\xffX\x04\x04\x02\x18\x08\x01\xff/\x00MTrk\x00\x00\x00\x16\x00\xc0\x00\x00\x90<@\x838<\x00\x00>@\x838>\x00\x01\xff/\x00"
         decoded = midi.decode_example({"bytes": fake_midi_bytes, "path": None})
         assert "notes" in decoded
         assert "tempo" in decoded
@@ -50,11 +43,10 @@ def test_audio_feature_decode_example(self):
     def test_audio_feature_with_dataset(self):
         features = Features({"midi": Midi()})
         data = {"midi": ["fake_path1.mid", "fake_path2.mid"]}
-        
-        with tempfile.TemporaryDirectory() as tmp_dir:
-            dataset = Dataset.from_dict(data, features=features)
-            assert "midi" in dataset.column_names
-            assert dataset.features["midi"].dtype == "dict"
+
+        dataset = Dataset.from_dict(data, features=features)
+        assert "midi" in dataset.column_names
+        assert dataset.features["midi"].dtype == "dict"
 
     def test_audio_feature_decode_false(self):
         midi = Midi(decode=False)
@@ -68,10 +60,10 @@ def test_audio_feature_resolution(self):
     def test_audio_feature_flatten(self):
         midi = Midi(decode=False)
         flattened = midi.flatten()
-        assert "bytes" in flattened
-        assert "path" in flattened
+        assert "bytes" in flattened  # type: ignore
+        assert "path" in flattened  # type: ignore
 
     def test_audio_feature_decode_error(self):
         midi = Midi(decode=False)
         with pytest.raises(RuntimeError):
-            midi.decode_example({"bytes": b"fake", "path": None})
+            midi.decode_example({"bytes": b"fake", "path": None})