Skip to content

Log VQ remapping configuration through the model logger - #13939

Closed
wunianze666-netizen wants to merge 1 commit into
huggingface:mainfrom
wunianze666-netizen:fix/vq-remap-logging
Closed

Log VQ remapping configuration through the model logger#13939
wunianze666-netizen wants to merge 1 commit into
huggingface:mainfrom
wunianze666-netizen:fix/vq-remap-logging

Conversation

@wunianze666-netizen

@wunianze666-netizen wunianze666-netizen commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • route VectorQuantizer remap configuration output through the model logger instead of writing directly to stdout
  • add a regression test that captures the remap message when remapping is enabled

Why

This message is emitted from library/model initialization code. Sending it to stdout makes it harder for downstream users to manage output, while the logger keeps the signal available without forcing terminal noise.

Validation

  • python -m pytest tests/models/autoencoders/test_models_vq.py -k test_vector_quantizer_logs_remap_configuration -q
  • ruff check src/diffusers/models/autoencoders/vae.py tests/models/autoencoders/test_models_vq.py
  • ruff format --check src/diffusers/models/autoencoders/vae.py tests/models/autoencoders/test_models_vq.py
  • python -m py_compile src/diffusers/models/autoencoders/vae.py tests/models/autoencoders/test_models_vq.py

Issue Linkage

This is a small logging cleanup and is not tied to an existing tracked issue.

@github-actions github-actions Bot added models tests size/L PR with diff > 200 LOC labels Jun 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi @wunianze666-netizen, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. Fixes #1234) to the PR description so the issue is linked. See the contribution guide for more details. If this PR intentionally does not fix a tracked issue, a maintainer can add the no-issue-needed label to silence this reminder.

@wunianze666-netizen

Copy link
Copy Markdown
Contributor Author

Closing this one-off PR in favor of the pattern-level coordination in #14479. I will wait for maintainer confirmation there, consolidate the approved scope, run the current self-review workflow, and include exact test results before opening a replacement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

models size/S PR with diff < 50 LOC tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant