-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw messages in text-generation task with deepseek r1 with PEFTModel #36783
Comments
cc @sayakpaul @BenjaminBossan for PEFT - if you think this is an issue in pipelines instead, let me know and I'll try to update our class matching logic! |
I'm not very familiar with pipelines but this is what I gather: I think we should check if peft is installed, and if it is, it should be added to the
|
@BenjaminBossan that makes sense! @falconlee236 would you be willing to attempt a PR for that? |
Hi @Rocketknight1 , i found this to be an interesting issue , and raised a PR fixing the same in #36868 . please have a look at it , i'll make any changes to it if required as soon as possible . thank you @falconlee236 for raising this issue . |
I tried to resolve the issue first, but @sambhavnoobcoder resolved it before me, so I don't feel great about it. At the very least, I wish you had submitted the PR after hearing my answer I want to be willing to attempt a PR |
so sorry @falconlee236 , that was not my intention in any way . please submit your pr , my curiosity just got the best of me . Please ignore my attempt and go ahead with your implementation . apologies for any inconvenience again . |
I'm happy for anyone to make the PR as long as it gets fixed! We generally don't "assign" issues to specific people - there's more than enough work to be done in the library |
I think I said that because I also want to contribute to Transformers. I'm sorry if it made you feel bad. @sambhavnoobcoder |
cool . in that case , i have reopened the PR and would appreciate your review @Rocketknight1 on the same . Also no worries @falconlee236 , i understand you also want to contribute to Transformers , and it would be my pleasure to contribute alongside you . i would also appreciate to learn more from your PR as well . |
System Info
Copy-and-paste the text below in your GitHub issue and FILL OUT the two last points.
transformers
version: 4.49.0- distributed_type: DEEPSPEED
- use_cpu: False
- debug: False
- num_processes: 1
- machine_rank: 0
- num_machines: 0
- rdzv_backend: static
- same_network: True
- main_training_function: main
- enable_cpu_affinity: False
- deepspeed_config: {'deepspeed_config_file': '/opt/config/train_config.json', 'zero3_init_flag': True}
- downcast_bf16: no
- tpu_use_cluster: False
- tpu_use_sudo: False
- tpu_env: []
Who can help?
@ArthurZucker @Rocketknight1 @muellerzr
Information
Tasks
examples
folder (such as GLUE/SQuAD, ...)Reproduction
lora_generator(text)
transformers/pipelines/base.py
that section was problemsExpected behavior
without unsupported models message.
This error might be occured the deepseek model was not in
supported_models
ListThe text was updated successfully, but these errors were encountered: