Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korrektur von Sprachwechsel und Spracheinstellung #22

Closed
windauer opened this issue Apr 26, 2023 · 6 comments
Closed

Korrektur von Sprachwechsel und Spracheinstellung #22

windauer opened this issue Apr 26, 2023 · 6 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@windauer
Copy link
Contributor

No description provided.

@windauer windauer added this to the Milestone 2 milestone Apr 26, 2023
@windauer windauer added the bug Something isn't working label Apr 26, 2023
@windauer
Copy link
Contributor Author

@arojascastro will provide more information

@tuurma
Copy link
Collaborator

tuurma commented Apr 26, 2023

Browser language settings take precedence over the selection made via the pb-lang component: this problem manifests in About and Team pages.

@windauer
Copy link
Contributor Author

windauer commented Apr 26, 2023

@tuurma sounds exactly like the issue I just recently fixed: eeditiones/tei-publisher-app#185

@arojascastro
Copy link
Collaborator

The problem lies in files about the project and team in /data:

  • about.xml (German)
  • about_en.xml (English)
  • about_es.xml (Spanish)
  • team.xml (German)
  • team_en.xml (English)
  • team_es,xml (Spanish)

We have tested the web application with users, whose language computer is English and Spanish, and they had troubles when accessing those pages: they were browsed by default in German and even when they switched the langauge manually to English or Spanish, the page did not load automatically to the selected languages.

Our expected behaviour is that the pages are accessed according to the language system of each user and that, when they select manually another language, that the page is refreshed automatically.

Please let me know if you need further questions or doubts.

@tuurma
Copy link
Collaborator

tuurma commented Jun 14, 2023

Also switching the language with the pb-lang has no effect on the content, only the pb-i18n labels

@tuurma
Copy link
Collaborator

tuurma commented Jun 14, 2023

Should be now fixed.

I've put in a placeholder for criterios_en.xml and criterios.xml needs to be translated to German, for the moment all hold Spanish content.

@tuurma tuurma closed this as completed Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants