Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expo from peer dependencies #67

Closed
mym0404 opened this issue Mar 27, 2024 · 1 comment · May be fixed by #68
Closed

Remove expo from peer dependencies #67

mym0404 opened this issue Mar 27, 2024 · 1 comment · May be fixed by #68

Comments

@mym0404
Copy link

mym0404 commented Mar 27, 2024

Describe the bug
It seems to this library works well with plain react-native project not expo only.

Could we remove expo peer dependency in package.json?

To Reproduce

  1. Use this package in plain react native project.
  2. Install package

Warning

warning " > @react-native-seoul/[email protected]" has unmet peer dependency "expo@*".

Additional Context
It seems to #60 also handle this topic.

@mym0404
Copy link
Author

mym0404 commented Mar 27, 2024

dup #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant