Randsel probablity is flipped with documentation (#162)

Author: mikeheddes

torchhd/functional.py

@@ -1104,7 +1104,7 @@ def randsel(
     other = ensure_vsa_tensor(other)
 
     select = torch.empty_like(input, dtype=torch.bool)
-    select.bernoulli_(1 - p, generator=generator)
+    select.bernoulli_(p, generator=generator)
     return input.where(select, other)
 
 

torchhd/tests/test_operations.py

@@ -272,7 +272,7 @@ def test_value(self, vsa, dtype):
         else:
             a, b = functional.random(2, 1024, vsa, dtype=dtype, generator=generator)
         res = functional.randsel(a, b, p=0, generator=generator)
-        assert torch.all(a == res)
+        assert torch.all(b == res)
 
         if vsa == "BSBC":
             a, b = functional.random(
@@ -281,7 +281,7 @@ def test_value(self, vsa, dtype):
         else:
             a, b = functional.random(2, 1024, vsa, dtype=dtype, generator=generator)
         res = functional.randsel(a, b, p=1, generator=generator)
-        assert torch.all(b == res)
+        assert torch.all(a == res)
 
         if vsa == "BSBC":
             a, b = functional.random(