Skip to content

Commit 0cf179f

Browse files
small typo fix in type (#1242)
Noticed this when resolving a conflict, should be `Chart` not `Chat` :P Fixes HDX-2553
1 parent 5efa2ff commit 0cf179f

File tree

5 files changed

+16
-12
lines changed

5 files changed

+16
-12
lines changed

.changeset/wicked-stingrays-tie.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@hyperdx/app": patch
3+
---
4+
5+
Fixes typo in type definition

packages/app/src/components/DBTableChart.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@ import { useMemo, useState } from 'react';
22
import { ClickHouseQueryError } from '@hyperdx/common-utils/dist/clickhouse';
33
import {
44
ChartConfigWithDateRange,
5-
ChartConfigWithOptDateRange,
6-
ChatConfigWithOptTimestamp,
5+
ChartConfigWithOptTimestamp,
76
} from '@hyperdx/common-utils/dist/types';
87
import { Box, Code, Text } from '@mantine/core';
98
import { SortingState } from '@tanstack/react-table';
@@ -21,7 +20,7 @@ export default function DBTableChart({
2120
enabled = true,
2221
queryKeyPrefix,
2322
}: {
24-
config: ChatConfigWithOptTimestamp;
23+
config: ChartConfigWithOptTimestamp;
2524
getRowSearchLink?: (row: any) => string;
2625
queryKeyPrefix?: string;
2726
enabled?: boolean;

packages/app/src/hooks/useOffsetPaginatedQuery.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
ColumnMetaType,
88
} from '@hyperdx/common-utils/dist/clickhouse';
99
import { renderChartConfig } from '@hyperdx/common-utils/dist/renderChartConfig';
10-
import { ChatConfigWithOptTimestamp } from '@hyperdx/common-utils/dist/types';
10+
import { ChartConfigWithOptTimestamp } from '@hyperdx/common-utils/dist/types';
1111
import {
1212
isFirstOrderByAscending,
1313
isTimestampExpressionInFirstOrderBy,
@@ -26,12 +26,12 @@ import { omit } from '@/utils';
2626

2727
type TQueryKey = readonly [
2828
string,
29-
ChatConfigWithOptTimestamp,
29+
ChartConfigWithOptTimestamp,
3030
number | undefined,
3131
];
3232
function queryKeyFn(
3333
prefix: string,
34-
config: ChatConfigWithOptTimestamp,
34+
config: ChartConfigWithOptTimestamp,
3535
queryTimeout?: number,
3636
): TQueryKey {
3737
return [prefix, config, queryTimeout];
@@ -130,7 +130,7 @@ function generateTimeWindowsAscending(startDate: Date, endDate: Date) {
130130

131131
// Get time window from page param
132132
function getTimeWindowFromPageParam(
133-
config: ChatConfigWithOptTimestamp,
133+
config: ChartConfigWithOptTimestamp,
134134
pageParam: TPageParam,
135135
): TimeWindow {
136136
const [startDate, endDate] = config.dateRange;
@@ -148,7 +148,7 @@ function getTimeWindowFromPageParam(
148148
function getNextPageParam(
149149
lastPage: TQueryFnData | null,
150150
allPages: TQueryFnData[],
151-
config: ChatConfigWithOptTimestamp,
151+
config: ChartConfigWithOptTimestamp,
152152
): TPageParam | undefined {
153153
if (lastPage == null) {
154154
return undefined;
@@ -428,7 +428,7 @@ function flattenData(data: TData | undefined): TQueryFnData | null {
428428
}
429429

430430
export default function useOffsetPaginatedQuery(
431-
config: ChatConfigWithOptTimestamp,
431+
config: ChartConfigWithOptTimestamp,
432432
{
433433
isLive,
434434
enabled = true,

packages/common-utils/src/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ export type DateRange = {
423423

424424
export type ChartConfigWithDateRange = ChartConfig & DateRange;
425425

426-
export type ChatConfigWithOptTimestamp = Omit<
426+
export type ChartConfigWithOptTimestamp = Omit<
427427
ChartConfigWithDateRange,
428428
'timestampValueExpression'
429429
> & {

packages/common-utils/src/utils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { z } from 'zod';
55

66
import {
77
ChartConfigWithDateRange,
8-
ChatConfigWithOptTimestamp,
8+
ChartConfigWithOptTimestamp,
99
DashboardFilter,
1010
DashboardFilterSchema,
1111
DashboardSchema,
@@ -547,7 +547,7 @@ export const removeTrailingDirection = (s: string) => {
547547
};
548548

549549
export const isTimestampExpressionInFirstOrderBy = (
550-
config: ChatConfigWithOptTimestamp,
550+
config: ChartConfigWithOptTimestamp,
551551
) => {
552552
const firstOrderingItem = getFirstOrderingItem(config.orderBy);
553553
if (!firstOrderingItem || config.timestampValueExpression == null)

0 commit comments

Comments
 (0)