up-41: add schema tests

Signed-off-by: toktar <[email protected]>

Author: toktar

indy_common/test/types/test_get_fee_schema.py

@@ -0,0 +1,20 @@
+from collections import OrderedDict
+
+from indy_common.types import ClientGetFeeOperation
+from plenum.common.messages.fields import ConstantField, LimitedLengthStringField
+
+EXPECTED_ORDERED_FIELDS = OrderedDict([
+    ("type", ConstantField),
+    ("alias", LimitedLengthStringField),
+])
+
+
+def test_has_expected_fields():
+    actual_field_names = OrderedDict(ClientGetFeeOperation.schema).keys()
+    assert actual_field_names == EXPECTED_ORDERED_FIELDS.keys()
+
+
+def test_has_expected_validators():
+    schema = dict(ClientGetFeeOperation.schema)
+    for field, validator in EXPECTED_ORDERED_FIELDS.items():
+        assert isinstance(schema[field], validator)

indy_common/test/types/test_get_fees_schema.py

@@ -0,0 +1,19 @@
+from collections import OrderedDict
+
+from indy_common.types import ClientGetFeesOperation
+from plenum.common.messages.fields import ConstantField
+
+EXPECTED_ORDERED_FIELDS = OrderedDict([
+    ("type", ConstantField),
+])
+
+
+def test_has_expected_fields():
+    actual_field_names = OrderedDict(ClientGetFeesOperation.schema).keys()
+    assert actual_field_names == EXPECTED_ORDERED_FIELDS.keys()
+
+
+def test_has_expected_validators():
+    schema = dict(ClientGetFeesOperation.schema)
+    for field, validator in EXPECTED_ORDERED_FIELDS.items():
+        assert isinstance(schema[field], validator)

indy_common/test/types/test_set_fees_schema.py

@@ -0,0 +1,20 @@
+from collections import OrderedDict
+
+from indy_common.types import ClientSetFeesOperation, SetFeesField
+from plenum.common.messages.fields import ConstantField
+
+EXPECTED_ORDERED_FIELDS = OrderedDict([
+    ("type", ConstantField),
+    ("fees", SetFeesField),
+])
+
+
+def test_has_expected_fields():
+    actual_field_names = OrderedDict(ClientSetFeesOperation.schema).keys()
+    assert actual_field_names == EXPECTED_ORDERED_FIELDS.keys()
+
+
+def test_has_expected_validators():
+    schema = dict(ClientSetFeesOperation.schema)
+    for field, validator in EXPECTED_ORDERED_FIELDS.items():
+        assert isinstance(schema[field], validator)

indy_common/types.py

@@ -467,14 +467,14 @@ class ClientGetRichSchemaObjectByMetadataOperation(MessageValidator):
     )
 
 
-class ClientGetFeeMsgOperation(MessageValidator):
+class ClientGetFeeOperation(MessageValidator):
     schema = (
         (TXN_TYPE, ConstantField(GET_FEE)),
         (FEES_ALIAS, LimitedLengthStringField(max_length=FEE_ALIAS_LENGTH)),
     )
 
 
-class ClientGetFeesMsgOperation(MessageValidator):
+class ClientGetFeesOperation(MessageValidator):
     schema = (
         (TXN_TYPE, ConstantField(GET_FEES)),
     )
@@ -491,7 +491,7 @@ def _specific_validation(self, val):
             return "set_fees -- " + error
 
 
-class ClientSetFeesMsgOperation(MessageValidator):
+class ClientSetFeesOperation(MessageValidator):
     schema = (
         (TXN_TYPE, ConstantField(SET_FEES)),
         (FEES, SetFeesField()),
@@ -528,9 +528,9 @@ class ClientOperationField(PClientOperationField):
         RICH_SCHEMA_PRES_DEF: ClientRichSchemaPresDefOperation(),
         GET_RICH_SCHEMA_OBJECT_BY_ID: ClientGetRichSchemaObjectByIdOperation(),
         GET_RICH_SCHEMA_OBJECT_BY_METADATA: ClientGetRichSchemaObjectByMetadataOperation(),
-        GET_FEE: ClientGetFeeMsgOperation(),
-        GET_FEES: ClientGetFeesMsgOperation(),
-        SET_FEES: ClientSetFeesMsgOperation(),
+        GET_FEE: ClientGetFeeOperation(),
+        GET_FEES: ClientGetFeesOperation(),
+        SET_FEES: ClientSetFeesOperation(),
     }
 
     # TODO: it is a workaround because INDY-338, `operations` must be a class