Skip to content

Commit 16cc1c8

Browse files
committed
Address comments
1 parent ab980fe commit 16cc1c8

3 files changed

Lines changed: 6 additions & 7 deletions

File tree

examples/multi_sig_user_set_abstraction.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010

1111
def main():
12-
_address, info, exchange = example_utils.setup(constants.TESTNET_API_URL, skip_ws=True)
12+
address, info, exchange = example_utils.setup(constants.TESTNET_API_URL, skip_ws=True)
1313
multi_sig_wallets = example_utils.setup_multi_sig_wallets()
1414

1515
# The outer signer is required to be an authorized user or an agent of an authorized user of the multi-sig user.
@@ -23,8 +23,9 @@ def main():
2323
abstraction = "disabled"
2424
timestamp = get_timestamp_ms()
2525

26-
# Use the human abstraction string here. Exchange.multi_sig canonicalizes this action to the wire enum value
27-
# when it builds and signs the outer multi-sig payload.
26+
# Must use the human abstraction string here. Exchange.multi_sig canonicalizes this action to the wire enum value
27+
# when it builds and signs the outer multi-sig payload. It is expected that the different signatures need different
28+
# versions of this value.
2829
action = {
2930
"type": "userSetAbstraction",
3031
"signatureChainId": "0x66eee",
@@ -44,7 +45,7 @@ def main():
4445
USER_SET_ABSTRACTION_SIGN_TYPES,
4546
"HyperliquidTransaction:UserSetAbstraction",
4647
multi_sig_user,
47-
exchange.wallet.address,
48+
address,
4849
)
4950
signatures.append(signature)
5051

hyperliquid/exchange.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,7 @@ def _get_dex(coin: str) -> str:
5757

5858

5959
USER_SET_ABSTRACTION_WIRE_VALUES = {
60-
"default": "e",
6160
"disabled": "i",
62-
"dexAbstraction": "d",
6361
"unifiedAccount": "u",
6462
"portfolioMargin": "p",
6563
}

hyperliquid/utils/types.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@
183183

184184
# b is the public address of the builder, f is the amount of the fee in tenths of basis points. e.g. 10 means 1 basis point
185185
BuilderInfo = TypedDict("BuilderInfo", {"b": str, "f": int})
186-
Abstraction = Literal["default", "dexAbstraction", "unifiedAccount", "portfolioMargin", "disabled"]
186+
Abstraction = Literal["unifiedAccount", "portfolioMargin", "disabled"]
187187
AgentAbstraction = Literal["u", "p", "i"]
188188

189189
PerpDexSchemaInput = TypedDict(

0 commit comments

Comments
 (0)