perf(query): Batch multiple get calls to badger while querying in handleValuePostings #8999
+148
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
all-seeing-code,
billprovince,
joshua-goldstein,
mangalaman93 and
meghalims
as code owners
ghost
added
area/testing
ghost
force-pushed
the
harshil-goel/batch-single
branch
from
5ff4744 to
5fd6e83
Compare
ghost
force-pushed
the
harshil-goel/single_key
branch
from
191f210 to
2a07e8b
Compare
ghost
force-pushed
the
harshil-goel/batch-single
branch
from
f8b36a6 to
4915b7d
Compare
ghost
force-pushed
the
harshil-goel/single_key
branch
from
2a07e8b to
d572cae
Compare
ghost
force-pushed
the
harshil-goel/batch-single
branch
2 times, most recently
from
31f9983 to
81491c5
Compare
ghost
force-pushed
the
harshil-goel/single_key
branch
from
d572cae to
29cb753
Compare
ghost
force-pushed
the
harshil-goel/batch-single
branch
from
81491c5 to
c6c87ce
Compare
ghost
force-pushed
the
harshil-goel/single_key
branch
2 times, most recently
from
80102bb to
e893711
Compare
ghost
force-pushed
the
harshil-goel/batch-single
branch
from
c6c87ce to
7ba5300
Compare
ghost
force-pushed
the
harshil-goel/single_key
branch
from
e893711 to
0ce037c
Compare
|
This PR has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open. |
ghost
force-pushed
the
harshil-goel/single_key
branch
from
0ce037c to
af560bd
Compare
ghost
self-requested a review
ghost
force-pushed
the
harshil-goel/single_key
branch
2 times, most recently
from
d8cef2a to
99e021e
Compare
ghost
force-pushed
the
harshil-goel/single_key
branch
2 times, most recently
from
e791681 to
873fddf
Compare
ghost
force-pushed
the
harshil-goel/single_key
branch
from
d6d5c3c to
bb72cb9
Compare
|
This PR has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open. |
|
Harshil Goel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
This PR has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open. |
|
closing PR for now, keeping branch active |
ghost
reopened this
ghost
self-requested a review
ghost
force-pushed
the
harshil-goel/batch-single
branch
3 times, most recently
from
762dd0c to
fbb5863
Compare
ghost
force-pushed
the
harshil-goel/batch-single
branch
from
fbb5863 to
15e9149
Compare
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title format:
Topic(Area): FeatureTopicmust be one ofbuild|ci|docs|feat|fix|perf|refactor|chore|testAreamust be one ofacl|audit|backup|badger|cdc|dql|export|graphql|indexing|multi-tenancy|raft|restore|upgrade|zeroBody Format:
Description:
Fixes:
Closes:
Docs: