Added Arms to spec-dependent enable/disable for warriors

Author: hypernormalisation

CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## [2.0.8] -- 2023-05-09
 
+### Added
+- Warriors now have the option to disable the swing timer when in Arms or Protection spec.
+
 ### Fixed
 - Fixed a bug where indeterminate ordering of evet callbacks was makinng the weapon checks for offhand and ranged lag behind
   equipment changes. This will fix a bug for warriors where ElvUI being loaded causes equipping a shield to break the offhand timer.

config_presets.lua

@@ -399,6 +399,7 @@ ST.WARRIOR.defaults = {
     bloodsurge_glow_line_length = 12,
 
     hide_in_tank_spec = false,
+    hide_in_arms_spec = false,
 
     -- Bar options
     ['**'] = ST.bar_defaults,

main.lua

@@ -164,11 +164,13 @@ function ST:show_bar(hand)
 				self:hide_bar(hand)
 			end
 		elseif self.player_class == "WARRIOR" then
-			if not (db_class.hide_in_tank_spec and self.has_devastate) then
+			if db_class.hide_in_tank_spec and self.has_devastate then
+				self:hide_bar(hand)
+			elseif db_class.hide_in_arms_spec and self.has_bladestorm then
+				self:hide_bar(hand)
+			else
 				self:get_bar_frame(hand):Show()
 				self:get_hiding_anchor_frame(hand):Show()
-			else
-				self:hide_bar(hand)
 			end
 		else
 			self:get_bar_frame(hand):Show()
@@ -806,9 +808,10 @@ function ST:get_druid_talent_info()
 end
 
 function ST:get_warrior_talent_info()
-	-- Function to determine if the player is in tank spec,
-	-- i.e. has Devastate talented.
+	-- Functions to get talents for specs that the user may want to hide
+	-- the swing timer in.
 	self.has_devastate = select(5, GetTalentInfo(3, 20)) == 1
+	self.has_bladestorm = select(5, GetTalentInfo(1, 27)) == 1
 end
 
 ------------------------------------------------------------------------------------
@@ -1051,25 +1054,13 @@ function ST:register_slashcommands()
 end
 
 function ST:test1()
-	-- local db = self:get_class_table()
-	-- if db.bars_locked then
-	-- 	self:Print("Unlocking bar frames")
-	-- 	db.bars_locked = false
-	-- 	self:unlock_frames()
-	-- else
-	-- 	self:Print("Locking bar frames")
-	-- 	db.bars_locked = true
-	-- 	self:lock_frames()
-	-- end
 end
 
 function ST:open_menu()
 	local ACD = LibStub("AceConfigDialog-3.0")
 	ACD:Open(addon_name.."_Options")
 end
 
-if st.debug then st.utils.print_msg('-- Parsed main1.lua module correctly') end
-
 --=========================================================================================
 -- Funcs to apply per-class settings
 --=========================================================================================
@@ -1086,3 +1077,8 @@ function ST:class_on_current_spell_cast_changed(is_cancelled)
 		self[c].on_current_spell_cast_changed(self, is_cancelled)
 	end
 end
+
+--=========================================================================================
+-- For debug and lua syntax errors
+--=========================================================================================
+if st.debug then st.utils.print_msg('-- Parsed main1.lua module correctly') end

option_tables.lua

@@ -653,17 +653,26 @@ function ST.class_opts_funcs.WARRIOR(self)
         tank_vid_header = {
             type = "header",
             order = 0.8,
-            name = "Hide when in tank spec"
+            name = "Spec-dependent enable/disable"
         },
         hide_in_tank_spec = {
             type = "toggle",
             order = 0.81,
-            name = "Enable",
-            desc = "When enabled, the timer will hide when the Warrior is in a tanking spec ("..
+            name = "Hide when Protection",
+            desc = "When enabled, the timer will hide when the Warrior is in Protection spec ("..
             "determined when Devastate is talented).",
             get = "getter",
             set = "setter",
         },
+        hide_in_arms_spec = {
+            type = "toggle",
+            order = 0.82,
+            name = "Hide when Arms",
+            desc = "When enabled, the timer will hide when the Warrior is in Arms spec ("..
+            "determined when Bladestorm is talented).",
+            get = "getter",
+            set = "setter",
+        },
         class_header = {
             type = "header",
             order = 1.0,