Skip to content

Commit 27cf5e5

Browse files
fix(ci): the BoJ trigger has never been a valid workflow (#74)
`⚙ Auto: BoJ server build trigger` has **failed every run it has ever had**, producing zero jobs and no log each time. ## Cause ```yaml if: ${{ vars.BOJ_SERVER_URL != '' || secrets.BOJ_SERVER_URL != '' }} ``` GitHub rejects this outright: ``` Invalid workflow file: Unrecognized named-value: 'secrets'. Located at position 30 within expression: vars.BOJ_SERVER_URL != '' || secrets.BOJ_SERVER_URL != '' ``` The **`secrets` context is not available in a job-level `if:`** — only in `env:`, `with:`, `run:`, and reusable-workflow inputs. So the file has never been a valid workflow, and the run dies during expression evaluation *before any job exists*. That is why it leaves no log and no check run: there is nothing to log. ## Why deleting the guard is the right fix It was redundant as well as broken. The step already does the same job correctly: ```yaml env: BOJ_URL: ${{ secrets.BOJ_SERVER_URL || vars.BOJ_SERVER_URL }} # legal here run: | if [ -z "$BOJ_URL" ]; then echo "BOJ_SERVER_URL not configured - skipping"; exit 0 fi ``` Removing the broken guard restores exactly the intended behaviour: a clean skip when the server is not configured. **A note on the alternative.** `lithoglyph` was already cured differently — by narrowing the guard to `if: ${{ vars.BOJ_SERVER_URL != '' }}`. That is valid, and its runs now show `skipped` rather than `failure`, which is how this diagnosis was confirmed against a control. But it silently breaks **secret-only** configuration, which this workflow's own header explicitly supports ("set `BOJ_SERVER_URL` as a repository secret **or** variable"). Deleting the guard honours the documented contract; narrowing it does not. ## Scope **51 repositories carry the identical broken line**, so 51 default branches have been permanently red on a workflow that has never once executed. This PR is one of that set. Because the workflow has never been valid, **this change cannot regress anything** — there is no working behaviour to lose. Found during the 2026-08-05 estate CI/CD census. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
1 parent 28d0df6 commit 27cf5e5

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

‎.github/workflows/boj-build.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ jobs:
1515
trigger-boj:
1616
runs-on: ubuntu-latest
1717
timeout-minutes: 10
18-
if: ${{ vars.BOJ_SERVER_URL != '' || secrets.BOJ_SERVER_URL != '' }}
1918
steps:
2019
- name: Checkout
2120
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

0 commit comments

Comments
 (0)