Commit 5fa7a83
Estate audit & optimization — Wave 0: kill the false green (holes before goals) (#453)
## Context
This is the first wave of a meticulous, estate-wide **must / should /
could / systems / compliance / effects** audit-and-uplift program
anchored in `standards` (the ~290-repo control plane). A 7-agent
read-only recon found the core problem: the *declarations* are rich but
the *enforcement is largely theatre* — validators pass vacuously,
mandatory-check runners aren't wired, and there's no post-action check
on agent claims. Per estate doctrine (`RSR-PHILOSOPHY.adoc`) the program
is ordered **holes before goals**, **solutions at source**, **always
fail loudly**.
This PR is the branch trunk; subsequent waves land as further commits.
## Wave 0 — Kill the false green (this commit)
Every validator that reported success while checking nothing, or masked
real errors behind `|| true`, is now state-aware and **provably able to
fail**, each backed by a red-team regression fixture.
| Fix | File | Hole closed |
|---|---|---|
| State-aware 6scm check | `a2ml/scripts/check-6scm.sh` | Exited 0
vacuously once `.scm` sources migrated to 6a2; now fails on
orphan-mirror drift / out-of-sync, and declares itself retired (not "in
sync") when obsolete |
| Real Mustfile validation | `.github/workflows/boj-build.yml` +
`scripts/check-mustfile-structure.sh` | Replaced `echo "K9 validation
would run here"` with a real structural check — every Mustfile check
must carry a severity + a means of discharge (`- run:` or `-
verification:`); hollow checks fail loudly |
| Arg parsing (#387) | `rhodium-standard-repositories/rsr-audit.sh` |
Documented `--format json` silently didn't work; invalid format now
exits 4 instead of defaulting to text; bare-positional form kept for
back-compat |
| De-mask `\|\| true` | `Justfile` `validate` +
`scripts/rsr-selfaudit.sh` | A broken audit (exit 4) was swallowed as
green; now a low grade is informational/non-blocking but an audit
*error* fails loudly. `registry-check` stays the hard gate |
| De-hardcode paths | `audit-contractiles.sh` | Removed
`/var/mnt/eclipse/...` owner-machine paths (couldn't run in CI); takes
args/`$CONTRACTILE_AUDIT_REPOS`, never audits zero repos |
## Verification
- `scripts/tests/wave0-false-green-test.sh` — **13/13**, exercising the
pass *and* fail path of every fixed validator (`just false-green-test`).
- Existing `check-workflow-staleness-test.sh` still passes;
`boj-build.yml` validates as YAML; all changed scripts pass `bash -n`.
- The real Mustfile passes structural validation (17 checks); a hollow
check fails; `rsr-audit --format json` emits JSON; an errored audit
fails `validate`.
## Not touched (by policy / scope)
- **Licence/SPDX** — flag-only throughout; no header edits.
- **`continue-on-error` soft-gates** — left in place (documented, with
real blocking equivalents elsewhere); honest-labelling / promotion is a
Wave 1 item, not a blanket removal that would manufacture red noise.
## Coming in later waves (same branch)
Wave 1 (wire the automation that never runs), Wave 3 (MUST/SHOULD/COULD
scorecards + compliance dashboard), Wave 4 (the
`did-you-actually-do-that` post-action claim-verifier spec — the missing
LLM-regulation tier), Wave 5 (AffineScript testing standard + template),
Wave 6 (campaign issues cross-linking #426/#451/#437/#381/#387/#446,
release hygiene).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---
_Generated by [Claude
Code](https://claude.ai/code/session_0114ps6mY5jAH4SzbGxeuYjc)_
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent 6df21b1 commit 5fa7a83
14 files changed
Lines changed: 538 additions & 36 deletions
File tree
- .github/workflows
- .machine_readable
- a2ml/scripts
- hooks
- rhodium-standard-repositories
- scripts
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
| 69 | + | |
69 | 70 | | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
78 | 85 | | |
79 | 86 | | |
80 | 87 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
135 | | - | |
| 135 | + | |
136 | 136 | | |
137 | 137 | | |
138 | | - | |
139 | | - | |
140 | | - | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| |||
216 | 216 | | |
217 | 217 | | |
218 | 218 | | |
219 | | - | |
| 219 | + | |
220 | 220 | | |
221 | 221 | | |
222 | 222 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
45 | 68 | | |
46 | | - | |
47 | | - | |
48 | | - | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
49 | 73 | | |
50 | 74 | | |
51 | 75 | | |
| |||
127 | 151 | | |
128 | 152 | | |
129 | 153 | | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
130 | 158 | | |
131 | 159 | | |
132 | 160 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
2 | 22 | | |
3 | 23 | | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
4 | 51 | | |
5 | | - | |
| 52 | + | |
6 | 53 | | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
| 54 | + | |
11 | 55 | | |
12 | 56 | | |
13 | 57 | | |
| |||
19 | 63 | | |
20 | 64 | | |
21 | 65 | | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
22 | 69 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
22 | 33 | | |
23 | 34 | | |
24 | 35 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
34 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
35 | 61 | | |
36 | 62 | | |
37 | 63 | | |
| |||
0 commit comments