Skip to content

hyper-spec does not require json #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
catmando opened this issue Jan 27, 2021 · 0 comments
Open

hyper-spec does not require json #341

catmando opened this issue Jan 27, 2021 · 0 comments
Labels
bug Something isn't working needs doc Everything is working, but documentation is needed.
Milestone

Comments

@catmando
Copy link
Contributor

newer Opal versions do not automatically include the json library, which hyper_spec depends on (depends on Object#to_json)

In most cases it doesn't matter since the json library will get included by some other dependency (i.e. opal-browser, opal-jquery, and most of the hyperstack gems)

There is however a chance that you could be using hyper-spec with a slimmed down opal App and get an error saying to_json aint there.

For now we can document that you have to require to_json (at least for test) but it would be nice to learn how to do this from within opal sprockets so it was automagic.

@catmando catmando added bug Something isn't working needs doc Everything is working, but documentation is needed. labels Jan 27, 2021
@catmando catmando added this to the Post Launch milestone Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs doc Everything is working, but documentation is needed.
Projects
None yet
Development

No branches or pull requests

1 participant