Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: UI filter buttons in expanded view of Explorer results remove previously chosen filters #1641

Open
cseas opened this issue May 27, 2022 · 3 comments · May be fixed by #1766
Open

Bug: UI filter buttons in expanded view of Explorer results remove previously chosen filters #1641

cseas opened this issue May 27, 2022 · 3 comments · May be fixed by #1766

Comments

@cseas
Copy link
Contributor

cseas commented May 27, 2022

Actual behaviour

Screenshot 2022-05-27 at 12 01 01 PM

When we add filters using the UI in Explorer page, they get added to the previously selected filters.

Screenshot 2022-05-27 at 12 21 58 PM

But when we select the filters from one of the attributes after expanding a search result, the filter removes all of the previously selected filters from the search bar.

Screenshot 2022-05-27 at 12 23 09 PM

Screenshot 2022-05-27 at 12 23 35 PM

Expected behaviour

Filters from the expanded view of results should also be added to the existing filters instead of replacing them entirely.

@cseas
Copy link
Contributor Author

cseas commented Jul 18, 2022

@cseas
Copy link
Contributor Author

cseas commented Jul 26, 2022

The filter in the top level explorer results works correctly because it is a filter-button that uses the addUrlFilter method.

The filter button in the expanded view of a result is buggy because it is instead a link that navigates to a URL with the new filter applied, completing wiping out any previously added filters.

@cseas cseas linked a pull request Jul 26, 2022 that will close this issue
3 tasks
@cseas
Copy link
Contributor Author

cseas commented Jul 26, 2022

Same bug exists in the Services page:

Screenshot_2022-07-26_at_9_51_52_AM

And also the API Endpoints page:

Screenshot_2022-07-26_at_9_55_56_AM

#1766 fixes the bug at these places as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant