Inconsistent behavior between agent-config on different platforms

[rcbjBlueMars]

Use Case

Slight inconsistency with how the other in-app agents support configs... the other agents (golang, nginx, java) support both adding the protocol and omitting the protocol from the reporting.endpoint. In python's case, it only supports endpoints prefixed with the protocol. If you drop the protocol, then the spans fail silently to be sent to the platform

so this works...

service_name: "python-svc"
reporting:
  endpoint: "http://localhost:4317"
  trace_reporter_type: "OTLP"

but this doesnt:

service_name: "python-svc"
reporting:
  endpoint: "localhost:4317"
  trace_reporter_type: "OTLP"

Proposal

Allow the OTLP span exporter endpoint config to take a value with or without the protocol specified.

If not protocol is specified, add 'http://' to the value passed to the OTLP exporter class.

Questions to address (if any)

[jcchavezs]

Makes sense to me. In golang it is the other way around, we need to drop the protocol due to the library it uses underneath. While this should be consistent across languages in upstream OTEL library we need to handle that inconsistency here.

…

On Wed, Jun 2, 2021 at 8:48 AM Robert C. Broeckelmann Jr. < ***@***.***> wrote: Use Case Slight inconsistency with how the other in-app agents support configs... the other agents (golang, nginx, java) support both adding the protocol and omitting the protocol from the reporting.endpoint. In python's case, it only supports endpoints prefixed with the protocol. If you drop the protocol, then the spans fail silently to be sent to the platform so this works... service_name: "nextroll-python-svc" reporting: endpoint: "http://localhost:4317" trace_reporter_type: "OTLP" but this doesnt: service_name: "nextroll-python-svc" reporting: endpoint: "localhost:4317" trace_reporter_type: "OTLP" Proposal Allow the OTLP span exporter endpoint config to take a value with or without the protocol specified. If not protocol is specified, add 'http://' to the value passed to the OTLP exporter class. Questions to address (if any) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#214>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXOYAU4CV2PRDGXX4LEOPDTQXH3JANCNFSM456DWILA> .

[jcchavezs]

Do you want to pick this up @shril