refactor: remove ignored patterns handling from extract logic

- Eliminated the handling of ignored path patterns and content tokens from the extractVariables function.
- Updated the Questions interface to remove the optional ignore property.
- Removed related test cases that checked for ignored patterns in the extraction process.

Author: sdqede

packages/create-gen-app/__tests__/create-gen.test.ts

@@ -564,39 +564,4 @@ module.exports = {
     });
   });
 
-  it("should respect ignore patterns from questions", async () => {
-    const ignoredDir = path.join(testTempDir, "__tests__");
-    fs.mkdirSync(ignoredDir);
-    fs.writeFileSync(
-      path.join(ignoredDir, "example.txt"),
-      "This file has ____ignored____ variable"
-    );
-    fs.writeFileSync(
-      path.join(testTempDir, ".questions.json"),
-      JSON.stringify({
-        ignore: ["__tests__"],
-        questions: [],
-      })
-    );
-
-    const result = await extractVariables(testTempDir);
-
-    expect(result.fileReplacers.map((r) => r.variable)).not.toContain("tests");
-    expect(result.contentReplacers.map((r) => r.variable)).not.toContain(
-      "IGNORED"
-    );
-  });
-
-  it("should skip default ignored content tokens", async () => {
-    fs.writeFileSync(
-      path.join(testTempDir, "jest.config.js"),
-      "// Match both __tests__ and colocated test files"
-    );
-
-    const result = await extractVariables(testTempDir);
-
-    expect(result.contentReplacers.map((r) => r.variable)).not.toContain(
-      "tests"
-    );
-  });
 });

packages/create-gen-app/src/template/extract.ts

@@ -30,24 +30,18 @@ export async function extractVariables(
   const contentReplacers: ContentReplacer[] = [];
   const fileReplacerVars = new Set<string>();
   const contentReplacerVars = new Set<string>();
-  
+
   const projectQuestions = await loadProjectQuestions(templateDir);
-  const ignoredPathPatterns = new Set<string>(projectQuestions?.ignore ?? []);
-  const ignoredContentTokens = buildIgnoredContentTokens(projectQuestions);
-  
   await walkDirectory(templateDir, async (filePath) => {
     const relativePath = path.relative(templateDir, filePath);
-    if (shouldIgnore(relativePath, ignoredPathPatterns)) {
-      return;
-    }
-    
+
     if (
       relativePath === ".questions.json" ||
       relativePath === ".questions.js"
     ) {
       return;
     }
-    
+
     const matches = relativePath.matchAll(VARIABLE_PATTERN);
     for (const match of matches) {
       const varName = match[1];
@@ -62,11 +56,8 @@ export async function extractVariables(
         });
       }
     }
-    
-    const contentVars = await extractFromFileContent(
-      filePath,
-      ignoredContentTokens
-    );
+
+    const contentVars = await extractFromFileContent(filePath);
     for (const varName of contentVars) {
       if (!contentReplacerVars.has(varName)) {
         contentReplacerVars.add(varName);
@@ -94,41 +85,36 @@ export async function extractVariables(
  * @returns Set of variable names found in the file
  */
 async function extractFromFileContent(
-  filePath: string,
-  ignoredTokens: Set<string>
+  filePath: string
 ): Promise<Set<string>> {
   const variables = new Set<string>();
-  
+
   return new Promise((resolve) => {
     const stream = fs.createReadStream(filePath, { encoding: "utf8" });
     let buffer = "";
-    
+
     stream.on("data", (chunk: string | Buffer) => {
       buffer += chunk.toString();
-      
+
       const lines = buffer.split("\n");
       buffer = lines.pop() || ""; // Keep the last incomplete line in buffer
-      
+
       for (const line of lines) {
         const matches = line.matchAll(VARIABLE_PATTERN);
         for (const match of matches) {
-          if (!shouldIgnoreContent(match[0], ignoredTokens)) {
           variables.add(match[1]);
-          }
         }
       }
     });
-    
+
     stream.on("end", () => {
       const matches = buffer.matchAll(VARIABLE_PATTERN);
       for (const match of matches) {
-        if (!shouldIgnoreContent(match[0], ignoredTokens)) {
         variables.add(match[1]);
-        }
       }
       resolve(variables);
     });
-    
+
     stream.on("error", () => {
       resolve(variables);
     });
@@ -145,10 +131,10 @@ async function walkDirectory(
   callback: (filePath: string) => Promise<void>
 ): Promise<void> {
   const entries = fs.readdirSync(dir, { withFileTypes: true });
-  
+
   for (const entry of entries) {
     const fullPath = path.join(dir, entry.name);
-    
+
     if (entry.isDirectory()) {
       await walkDirectory(fullPath, callback);
     } else if (entry.isFile()) {
@@ -194,98 +180,6 @@ async function loadProjectQuestions(
   return null;
 }
 
-function shouldIgnore(
-  relativePath: string,
-  ignoredPatterns: Set<string>
-): boolean {
-  if (ignoredPatterns.size === 0) {
-    return false;
-  }
-  const normalized = relativePath.split(path.sep).join("/");
-  const segments = normalized.split("/");
-
-  for (const pattern of ignoredPatterns) {
-    const normalizedPattern = pattern.split(path.sep).join("/");
-
-    if (normalizedPattern === normalized) {
-      return true;
-    }
-
-    if (!normalizedPattern.includes("/")) {
-      if (segments.includes(normalizedPattern)) {
-        return true;
-      }
-      continue;
-    }
-
-    if (normalizedPattern.startsWith("**/")) {
-      const suffix = normalizedPattern.slice(3);
-      if (normalized.endsWith(suffix)) {
-        return true;
-      }
-      continue;
-    }
-
-    if (normalizedPattern.endsWith("/**")) {
-      const prefix = normalizedPattern.slice(0, -3);
-      if (normalized === prefix || normalized.startsWith(`${prefix}/`)) {
-        return true;
-      }
-      continue;
-    }
-
-    if (normalized.startsWith(`${normalizedPattern}/`)) {
-      return true;
-    }
-  }
-  return false;
-}
-
-const DEFAULT_IGNORED_CONTENT_TOKENS = ["tests", "snapshots"];
-
-function shouldIgnoreContent(
-  match: string,
-  ignoredTokens: Set<string>
-): boolean {
-  if (ignoredTokens.size === 0) {
-    return false;
-  }
-  const token = match.slice(
-    PLACEHOLDER_BOUNDARY.length,
-    -PLACEHOLDER_BOUNDARY.length
-  );
-  return ignoredTokens.has(token);
-}
-
-function buildIgnoredContentTokens(projectQuestions: Questions | null): Set<string> {
-  const tokens = new Set<string>(DEFAULT_IGNORED_CONTENT_TOKENS);
-  if (projectQuestions?.ignore) {
-    for (const entry of projectQuestions.ignore) {
-      const normalized = normalizePlaceholder(entry);
-      if (normalized) {
-        tokens.add(normalized);
-      }
-    }
-  }
-  return tokens;
-}
-
-function normalizePlaceholder(entry: string): string | null {
-  if (
-    entry.startsWith(PLACEHOLDER_BOUNDARY) &&
-    entry.endsWith(PLACEHOLDER_BOUNDARY)
-  ) {
-    return entry.slice(
-      PLACEHOLDER_BOUNDARY.length,
-      -PLACEHOLDER_BOUNDARY.length
-    );
-  }
-  if (entry.startsWith("__") && entry.endsWith("__")) {
-    return entry.slice(2, -2);
-  }
-  return entry || null;
-}
-
 /**
  * Normalize questions by ensuring all required fields have default values
  * @param questions - Questions object to normalize

packages/create-gen-app/src/types.ts

@@ -7,7 +7,6 @@ import { Question } from 'inquirerer';
  */
 export interface Questions {
   questions: Question[];
-  ignore?: string[];
 }
 
 /**