Create Gen App – tighten prompt mapping, simplify extraction, and refresh integration tests #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed answer keys from uppercase to camelCase in integration-helpers.ts for better readability and consistency. - Updated corresponding test assertions in cli.test.ts to reflect the new key names.
- Eliminated the handling of ignored path patterns and content tokens from the extractVariables function. - Updated the Questions interface to remove the optional ignore property. - Removed related test cases that checked for ignored patterns in the extraction process.
- Added utility functions to find license values, authors, and emails from user answers. - Refactored license file generation to utilize the new functions for improved readability and maintainability. - Removed the deprecated getAnswer function to streamline the codebase.
- Updated test cases to require exact CLI override names and prevent mapping of similar substring overrides. - Refactored promptUser function to streamline answer merging and removed unnecessary functions related to identifier matching. - Enhanced clarity in variable mapping by ensuring undefined values are handled correctly.
…descriptions - Updated test case to clarify that overlapping template variables should not be hydrated implicitly. - Adjusted assertions to ensure that the expected behavior aligns with the new logic. - Enhanced integration helper functions to include a description field for better test clarity. - Updated snapshot tests to reflect changes in package.json descriptions and repository URLs for consistency.
pyramation
reviewed
Dec 1, 2025
| const passedArgv = mockPrompt.mock.calls[0][0]; | ||
| expect(passedArgv.description).toBe("CLI description"); | ||
| expect(passedArgv.description).toBeUndefined(); | ||
| expect(passedArgv.MODULEDESC).toBe("CLI description"); |
Contributor
There was a problem hiding this comment.
where do these ALL CAPS come from?
pyramation
reviewed
Dec 1, 2025
| const passedArgv = mockPrompt.mock.calls[0][0]; | ||
| expect(passedArgv.fullName).toBe("CLI User"); | ||
| expect(passedArgv.fullName).toBeUndefined(); | ||
| expect(passedArgv.USERFULLNAME).toBe("CLI User"); |
Contributor
There was a problem hiding this comment.
where do these ALL CAPS come from?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Refactor & Test Update Plan
• Require exact CLI override keys inside promptUser.
• Remove fuzzy identifier matching/expansion helpers entirely.
• Update all related unit tests to expect strict, literal key matching.
⸻
• Drop support for .questions ignore handling.
• Remove content-token skipping logic.
• Update the Questions type to reflect this simplified model.
• Refresh and adjust unit tests to match the new streamlined behavior.
⸻
• Move all license-answer lookup logic into licenses.ts.
• Reuse the centralized functions inside replace.ts, ensuring a single source of truth.
⸻
• Standardize all integration helper keys to camelCase (including description).
• Refresh snapshot tests.
• Update CLI harness to ensure:
• correct --no-tty behavior,
• non-interactive module generation by default.
⸻
• Update tests to reflect:
• the new template outputs,
• revised non-interactive behavior,
• updated snapshot structures.
⸻
🧪 Testing Commands
Run full test suites:
pnpm --filter create-gen-app test
pnpm --filter create-gen-app-test test