You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we're catching ValueErrors raised by the post_process function and assuming they indicate a storage that doesn't support progressive post-processing, however, this isn't the case. The storage may throw a ValueError for another reason or, worse, it could fail to raise an exception and simply return the wrong URL (for example, if the storage contains an old version of the file).
One possible fix is to add a flag to storage objects to indicate that they generate URLs without requiring a copy of the file on the storage (local_urls?). (Though this might be a little strange/a deviation from expected behavior.) If the flag is not present (or its value is False), eccollect should fail early.
Currently, we're catching ValueErrors raised by the
post_process
function and assuming they indicate a storage that doesn't support progressive post-processing, however, this isn't the case. The storage may throw a ValueError for another reason or, worse, it could fail to raise an exception and simply return the wrong URL (for example, if the storage contains an old version of the file).One possible fix is to add a flag to storage objects to indicate that they generate URLs without requiring a copy of the file on the storage (
local_urls
?). (Though this might be a little strange/a deviation from expected behavior.) If the flag is not present (or its value isFalse
), eccollect should fail early.Related: #6
The text was updated successfully, but these errors were encountered: