Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Flag on Storage Before Doing Progressive Post-Processing #10

Open
matthewwithanm opened this issue Feb 12, 2013 · 3 comments
Open
Assignees

Comments

@matthewwithanm
Copy link
Contributor

Currently, we're catching ValueErrors raised by the post_process function and assuming they indicate a storage that doesn't support progressive post-processing, however, this isn't the case. The storage may throw a ValueError for another reason or, worse, it could fail to raise an exception and simply return the wrong URL (for example, if the storage contains an old version of the file).

One possible fix is to add a flag to storage objects to indicate that they generate URLs without requiring a copy of the file on the storage (local_urls?). (Though this might be a little strange/a deviation from expected behavior.) If the flag is not present (or its value is False), eccollect should fail early.

Related: #6

@matthewwithanm
Copy link
Contributor Author

@kenzic Any interest in taking this on? (:

@kenzic
Copy link
Contributor

kenzic commented Feb 13, 2013

Assigning!

@ghost ghost assigned kenzic Feb 13, 2013
@matthewwithanm
Copy link
Contributor Author

💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants