Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Whitelist not being read correctly on win10 + smplayer #192

Open
lamegreen opened this issue Jun 6, 2022 · 4 comments
Open

[BUG] Whitelist not being read correctly on win10 + smplayer #192

lamegreen opened this issue Jun 6, 2022 · 4 comments
Labels
bug Something isn't working monitor Concerning a player monitor wontfix This will not be worked on

Comments

@lamegreen
Copy link

image

Whitelist always gets saved with backslashes while the filepath outputted by smplayer is with forward slashes. Doing trakts whitelist test E:/Shows and Movies/Shows gives "The path is not in whitelist!" while doing trakts whitelist test E:\Shows and Movies\Shows works as it should.

Desktop (please complete the following information):

  • OS and Version: Windows 10
  • Python Version: 3.10.4
  • Player and Version: SMPlayer Version: 22.2.0 (revision 10060) (64-bit)

To Reproduce

Play any file in the whitelisted directory

Log file

Click to see log contents

2022-06-05 04:28:18,486 - DEBUG - MainThread - notifier - Notifications enabled for categories: exception, misc, scrobble.pause, scrobble.resume, scrobble.start, scrobble.stop, trakt
2022-06-05 04:28:18,615 - INFO - MainThread - scrobbler - Started scrobbler thread.
2022-06-05 04:28:18,644 - DEBUG - MainThread - monitor - Autoloaded smplayer@mpv ipc_path = \\.\pipe\mpvsocket
2022-06-05 04:28:18,645 - INFO - MainThread - monitor - Started monitor for smplayer@mpv
2022-06-05 04:28:18,656 - DEBUG - smplayer@mpv - file_info - Raw filepath 'E:/Shows and Movies/Shows/The Boys/Season 3/The Boys - S03E01 - Payback WEBDL-1080p.mkv'
2022-06-05 04:28:18,657 - INFO - smplayer@mpv - file_info - File path not in whitelist.

@lamegreen
Copy link
Author

lamegreen commented Jun 7, 2022

Adding the folders by doing trakts config set fileinfo.whitelist --add E:/Shows and Movies/Shows instead of trakts whitelist add seemed to fix it

@iamkroot
Copy link
Owner

iamkroot commented Jun 8, 2022

2022-06-05 04:28:18,656 - DEBUG - smplayer@mpv - file_info - Raw filepath 'E:/Shows and Movies/Shows/The Boys/Season 3/The Boys - S03E01 - Payback WEBDL-1080p.mkv'

This is the weird part. I'm not exactly sure why it has forward slashes here. Being on Windows, it should be \.

Glad to see that you found a workaround. But I'd like to keep this issue open, will try to investigate when I have some time.

@iamkroot iamkroot added the bug Something isn't working label Jun 8, 2022
@iamkroot
Copy link
Owner

Ok, I looked into this- seems like it is an upstream SMPlayer bug. It directly sends the path with forward slashes to MPV when starting the file. So when we query MPV, we also get the same path. Not sure if we want manually fix the paths, since it might break web urls (which do require forward slashes).

@iamkroot iamkroot added wontfix This will not be worked on monitor Concerning a player monitor labels Jul 6, 2022
@dbarkar
Copy link

dbarkar commented Oct 2, 2022

I'm having the same issue with VLC on Windows 11.
trakts doesn't recognize the path when video is playing, but trakts test works.
Fixed by @lamegreen 's workaround, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working monitor Concerning a player monitor wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants