Skip to content

Commit df34951

Browse files
NickCrewsjcrist
authored andcommitted
test(sql): do more than a smoketest in test_literal()
This still isn't much meat in this test, but it is a little more substantial now.
1 parent c23e487 commit df34951

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

ibis/backends/tests/test_sql.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
@pytest.mark.parametrize(
1515
"expr",
1616
[
17-
param(ibis.literal(1), id="simple_literal"),
17+
param(ibis.literal(432), id="simple_literal"),
1818
param(
19-
ibis.array([1]),
19+
ibis.array([432]),
2020
marks=[
2121
pytest.mark.never(
2222
["mysql", "mssql", "oracle", "impala", "sqlite"],
@@ -27,7 +27,7 @@
2727
id="array_literal",
2828
),
2929
param(
30-
ibis.struct(dict(a=1)),
30+
ibis.struct(dict(abc=432)),
3131
marks=[
3232
pytest.mark.never(
3333
["impala", "mysql", "sqlite", "mssql", "exasol"],
@@ -49,7 +49,7 @@
4949
)
5050
@pytest.mark.notimpl(["polars"], reason="Not clear how to extract SQL from the backend")
5151
def test_literal(backend, expr):
52-
assert ibis.to_sql(expr, dialect=backend.name())
52+
assert "432" in ibis.to_sql(expr, dialect=backend.name())
5353

5454

5555
@pytest.mark.never(["pandas", "dask", "polars"], reason="not SQL")

0 commit comments

Comments
 (0)