Skip to content

Publish Location code under PCIeDevice schema (#1083) #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rfrandse merged 1 commit into from
Apr 29, 2025
Merged

Publish Location code under PCIeDevice schema (#1083) #1239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions redfish-core/lib/pcie.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,33 @@ inline void getPCIeDeviceAsset(
});
}

inline void getPCIeDeviceLocation(
const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
const std::string& pcieDevicePath, const std::string& service)
{
dbus::utility::getProperty<std::string>(
service, pcieDevicePath,
"xyz.openbmc_project.Inventory.Decorator.LocationCode", "LocationCode",
[asyncResp](const boost::system::error_code& ec,
const std::string& property) {
if (ec)
{
if (ec.value() != EBADR)
{
BMCWEB_LOG_ERROR(
"DBUS response error for Location. Error code: {}",
ec.value());
messages::internalError(asyncResp->res);
}
return;
}

asyncResp->res
.jsonValue["Slot"]["Location"]["PartLocation"]["ServiceLabel"] =
property;
});
}

inline void addPCIeDeviceProperties(
const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
const std::string& pcieDeviceId,
Expand Down Expand Up @@ -679,6 +706,7 @@ inline void afterGetValidPcieDevicePath(
std::bind_front(afterGetPCIeDeviceSlotPath, asyncResp));
name_util::getPrettyName(asyncResp, pcieDevicePath, service,
nlohmann::json::json_pointer{"/Name"});
getPCIeDeviceLocation(asyncResp, pcieDevicePath, service);
}

inline void handlePCIeDeviceGet(
Expand Down