Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfurled Image and Avatars for remote users should be stored, not cached #2981

Open
lindner opened this issue Aug 23, 2021 · 1 comment
Open

Comments

@lindner
Copy link
Collaborator

lindner commented Aug 23, 2021

Is your feature request related to a problem? Please describe.

If furled content changes the image preview can disappear or change. Leading to a display that is not acceptable.

Avatar changes and account deletions can also leave poor broken image results.

Describe the solution you'd like

Unfurled images should be stored and not cached.

For comments that users leave on remote platforms (twitter/mastodon) the fetched image should be stored locally and not cached..

@mapkyca
Copy link
Member

mapkyca commented Aug 24, 2021

Cache = Store, really. But, perhaps some tweaking to the logic would work.

The image proxy obeys cache headers, and I think also obeys http statuses. Perhaps an approach would be to check for non 200 codes on images and not replace the old image if the new one couldn't be retrieved.... I thought it did that already, but I wrote that code so long ago!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants