Skip to content

Commit 0838b58

Browse files
igerberclaude
andcommitted
Fix CI review R2: scope parity claim, correct fit() API signature
- Slide 8: "ATT matches R across joiners, leavers, and controls" -> "ATT validated against R reference outputs" - Slide 7: move L_max and placebo from constructor to fit() where they belong, drop HonestDiD from caption (covered on slide 5) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 881f50b commit 0838b58

2 files changed

Lines changed: 8 additions & 9 deletions

File tree

0 Bytes
Binary file not shown.

carousel/generate_dcdh_carousel.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -799,12 +799,7 @@ def slide_07_code(self):
799799
[(")", WHITE)],
800800
[], # blank
801801
[("est", WHITE), (" = ", TEAL),
802-
("DCDH", GREEN_CODE), ("(", WHITE)],
803-
[(" ", WHITE), ("L_max", WHITE), ("=", TEAL),
804-
("3", TEAL_LIGHT), (", ", WHITE),
805-
("placebo", WHITE), ("=", TEAL),
806-
("True", TEAL_LIGHT), (")", WHITE)],
807-
[], # blank
802+
("DCDH", GREEN_CODE), ("()", WHITE)],
808803
[("results", WHITE), (" = ", TEAL),
809804
("est.fit(", WHITE)],
810805
[(" data,", WHITE)],
@@ -815,7 +810,11 @@ def slide_07_code(self):
815810
[(" ", WHITE), ("time", WHITE), ("=", TEAL),
816811
("'week'", GREEN_CODE), (",", WHITE)],
817812
[(" ", WHITE), ("treatment", WHITE), ("=", TEAL),
818-
("'targeted'", GREEN_CODE), (")", WHITE)],
813+
("'targeted'", GREEN_CODE), (",", WHITE)],
814+
[(" ", WHITE), ("L_max", WHITE), ("=", TEAL),
815+
("3", TEAL_LIGHT), (", ", WHITE),
816+
("placebo", WHITE), ("=", TEAL),
817+
("True", TEAL_LIGHT), (")", WHITE)],
819818
[], # blank
820819
[("plot_event_study", WHITE), ("(results)", SLATE_400)],
821820
]
@@ -827,7 +826,7 @@ def slide_07_code(self):
827826
# Subtitle — keep above footer (rule at HEIGHT-28)
828827
sub_y = min(code_y + code_h + 18, HEIGHT - 48)
829828
self.centered_text(sub_y,
830-
"Placebos, event study, HonestDiD - all from one fit() call.",
829+
"Placebos, event study, bootstrap - all from one fit() call.",
831830
size=14, bold=False, color=SLATE_400)
832831

833832
self.add_footer()
@@ -868,7 +867,7 @@ def slide_08_validation(self):
868867

869868
items = [
870869
("Point Estimate Parity",
871-
"ATT matches R across joiners, leavers, and controls"),
870+
"ATT validated against R reference outputs"),
872871
("SE Parity (pure-direction)",
873872
"Analytical SEs match R on joiners-only and leavers-only"),
874873
("HonestDiD Integration",

0 commit comments

Comments
 (0)