Fix StaggeredTripleDifference unpack for 3-tuple _aggregate_simple return

igerber · claude · igerber · commit 08822e16fe01 · 2026-03-30T21:04:21.000-04:00
_aggregate_simple() now returns (att, se, effective_df). Update the
StaggeredTripleDifference caller to unpack the third element.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/diff_diff/staggered_triple_diff.py b/diff_diff/staggered_triple_diff.py
@@ -442,7 +442,7 @@ def fit(
         df_agg.loc[df_agg[eligibility] == 0, "first_treat"] = 0
 
         # Overall ATT via aggregation mixin
-        overall_att, overall_se = self._aggregate_simple(
+        overall_att, overall_se, _effective_df = self._aggregate_simple(
             group_time_effects, influence_func_info, df_agg, unit, precomputed_agg
         )
         overall_t_stat, overall_p_value, overall_conf_int = safe_inference(

Original file line number	Diff line number	Diff line change
`@@ -442,7 +442,7 @@ def fit(`
`442`	`442`	`df_agg.loc[df_agg[eligibility] == 0, "first_treat"] = 0`
`443`	`443`
`444`	`444`	`# Overall ATT via aggregation mixin`
`445`		`- overall_att, overall_se = self._aggregate_simple(`
	`445`	`+ overall_att, overall_se, _effective_df = self._aggregate_simple(`
`446`	`446`	`group_time_effects, influence_func_info, df_agg, unit, precomputed_agg`
`447`	`447`	`)`
`448`	`448`	`overall_t_stat, overall_p_value, overall_conf_int = safe_inference(`