Skip to content

Commit 13c7595

Browse files
igerberclaude
andcommitted
Fix CI: extension-module feature and wheel installation
- Move pyo3/extension-module to optional feature (not needed for tests) - Update pyproject.toml to use the new feature name - Use pip --find-links for wheel installation (glob wasn't expanding) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 7de594d commit 13c7595

3 files changed

Lines changed: 8 additions & 3 deletions

File tree

.github/workflows/rust-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ jobs:
8181
run: |
8282
pip install maturin
8383
maturin build --release
84-
pip install target/wheels/*.whl
84+
pip install --find-links=target/wheels diff-diff
8585
8686
- name: Verify Rust backend is available
8787
run: |

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ Issues = "https://github.com/igerber/diff-diff/issues"
5757

5858
[tool.maturin]
5959
# Build the Rust extension module
60-
features = ["pyo3/extension-module"]
60+
features = ["extension-module"]
6161
# Python source is in the root directory
6262
python-source = "."
6363
# Module name for the compiled extension

rust/Cargo.toml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,13 @@ name = "diff_diff_rust"
1010
# cdylib for Python extension, rlib for running tests
1111
crate-type = ["cdylib", "rlib"]
1212

13+
[features]
14+
default = []
15+
# extension-module is only needed for cdylib builds, not for cargo test
16+
extension-module = ["pyo3/extension-module"]
17+
1318
[dependencies]
14-
pyo3 = { version = "0.20", features = ["extension-module"] }
19+
pyo3 = "0.20"
1520
numpy = "0.20"
1621
ndarray = { version = "0.15", features = ["rayon"] }
1722
rand = "0.8"

0 commit comments

Comments
 (0)