Commit 16d7792
Address PR #440 R3 review (1 P1 — same class, different §4 site)
R2 fixed two §4/§5 sites that misframed event-study mechanics. R3
reviewer caught a third site at the §4 cell that introduces the
per-horizon SE-ratio table (`L422-426`). It said the post-period
horizons "aggregate across all post-period observations" and the
variance is "read off the full panel" — wrong. HAD event-study
fits each horizon as a SEPARATE local-linear on that horizon's
first differences (`ΔY_{g,t} = Y_{g,t} - Y_{g,F-1}`) against the
common `D_{g,F}` regressor (paper Appendix B.2;
`diff_diff/had.py:4298-4451`); the pointwise per-horizon SE reads
each horizon's own residual variance, not a panel aggregate.
Also softened the "per-horizon SE ratio should be larger than the
overall ratio" claim — the empirical per-horizon ratios on the
locked seed are mixed ([1.087, 1.0, 0.816, 1.203, 1.127, 1.085,
1.126]), some larger and some smaller than the overall ~1.10x. The
revised text frames this as an empirical observation of how PSU
correlation interacts with each horizon's `ΔY` distribution, NOT a
methodological guarantee.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent ba99bc9 commit 16d7792
1 file changed
Lines changed: 9 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
419 | 419 | | |
420 | 420 | | |
421 | 421 | | |
422 | | - | |
423 | | - | |
424 | | - | |
425 | | - | |
426 | | - | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
427 | 431 | | |
428 | 432 | | |
429 | 433 | | |
| |||
0 commit comments