Skip to content

Commit 16d7792

Browse files
igerberclaude
andcommitted
Address PR #440 R3 review (1 P1 — same class, different §4 site)
R2 fixed two §4/§5 sites that misframed event-study mechanics. R3 reviewer caught a third site at the §4 cell that introduces the per-horizon SE-ratio table (`L422-426`). It said the post-period horizons "aggregate across all post-period observations" and the variance is "read off the full panel" — wrong. HAD event-study fits each horizon as a SEPARATE local-linear on that horizon's first differences (`ΔY_{g,t} = Y_{g,t} - Y_{g,F-1}`) against the common `D_{g,F}` regressor (paper Appendix B.2; `diff_diff/had.py:4298-4451`); the pointwise per-horizon SE reads each horizon's own residual variance, not a panel aggregate. Also softened the "per-horizon SE ratio should be larger than the overall ratio" claim — the empirical per-horizon ratios on the locked seed are mixed ([1.087, 1.0, 0.816, 1.203, 1.127, 1.085, 1.126]), some larger and some smaller than the overall ~1.10x. The revised text frames this as an empirical observation of how PSU correlation interacts with each horizon's `ΔY` distribution, NOT a methodological guarantee. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent ba99bc9 commit 16d7792

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

docs/tutorials/22_had_survey_design.ipynb

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -419,11 +419,15 @@
419419
"and only a small share of states near the boundary, the within-PSU\n",
420420
"correlation has a small lever to act on.\n",
421421
"\n",
422-
"Contrast with the event-study path: the post-period horizons aggregate\n",
423-
"across **all post-period observations**, so the variance is read off\n",
424-
"the full panel and the survey-design machinery has more cluster\n",
425-
"correlation to amplify. The per-horizon SE ratio should be larger\n",
426-
"than the overall SE ratio:\n"
422+
"Contrast with the event-study path: each event-time horizon is a\n",
423+
"**separate** local-linear fit on that horizon's first differences\n",
424+
"`ΔY_{g,t} = Y_{g,t} - Y_{g,F-1}` against the common regressor\n",
425+
"`D_{g,F}` (paper Appendix B.2). The pointwise per-horizon SE is\n",
426+
"computed from each horizon's own residual variance — not aggregated\n",
427+
"across post-period observations. So the per-horizon survey-vs-naive\n",
428+
"ratio is an empirical property of how PSU correlation interacts with\n",
429+
"each horizon's `ΔY` distribution on this seeded DGP, not a\n",
430+
"method-contract guarantee. We compute it below to inspect:\n"
427431
]
428432
},
429433
{

0 commit comments

Comments
 (0)