Commit 1d8e16b
Address PR #401 R1 review (2 P3 housekeeping items)
R1 verdict was "Looks good". Two P3 housekeeping items addressed:
P3 (maintainability): `summary()` and `to_dataframe(level="by_path")`
re-sorted output by `frequency_rank`, dropping the user-specified
order under `paths_of_interest`. Both reporting surfaces now iterate
in `path_effects` insertion order so user-specified order is
preserved end-to-end. Under `by_path=k`, insertion order matches
descending frequency_rank so output is identical to the prior
release. Adds regressions
`test_paths_of_interest_order_preserved_in_to_dataframe` and
`test_paths_of_interest_order_preserved_in_summary`.
P3 (docs): remaining `by_path`-only language in result docs and
REGISTRY:
- `chaisemartin_dhaultfoeuille_results.py` `path_sup_t_bands` empty-
state contract: "no bootstrap or `by_path is None`" -> "no
bootstrap, or both `by_path` and `paths_of_interest` are `None`"
- `chaisemartin_dhaultfoeuille_results.py` `to_dataframe(level=
"by_path")` ValueError text: pass `paths_of_interest` as an
alternative to `by_path=k`
- `docs/methodology/REGISTRY.md:643` joint sup-t bands Note:
empty-state contract updated for both selectors
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 7df7dc2 commit 1d8e16b
3 files changed
Lines changed: 76 additions & 13 deletions
File tree
- diff_diff
- docs/methodology
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
455 | 455 | | |
456 | 456 | | |
457 | 457 | | |
458 | | - | |
459 | | - | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
460 | 461 | | |
461 | 462 | | |
462 | 463 | | |
| |||
1285 | 1286 | | |
1286 | 1287 | | |
1287 | 1288 | | |
1288 | | - | |
1289 | | - | |
1290 | | - | |
1291 | | - | |
| 1289 | + | |
| 1290 | + | |
| 1291 | + | |
| 1292 | + | |
| 1293 | + | |
1292 | 1294 | | |
1293 | 1295 | | |
1294 | 1296 | | |
| |||
1698 | 1700 | | |
1699 | 1701 | | |
1700 | 1702 | | |
1701 | | - | |
| 1703 | + | |
| 1704 | + | |
1702 | 1705 | | |
1703 | | - | |
| 1706 | + | |
| 1707 | + | |
1704 | 1708 | | |
1705 | 1709 | | |
1706 | 1710 | | |
| |||
1723 | 1727 | | |
1724 | 1728 | | |
1725 | 1729 | | |
1726 | | - | |
1727 | | - | |
1728 | | - | |
1729 | | - | |
| 1730 | + | |
| 1731 | + | |
| 1732 | + | |
| 1733 | + | |
| 1734 | + | |
1730 | 1735 | | |
1731 | 1736 | | |
1732 | 1737 | | |
| |||
0 commit comments