Address PR #376 R10 (2 P3)

R10 P3 #1 (qug_test deprecation warning text): qug_test was using the
shared array-in deprecation messages that point users to migrate to
`survey_design=` / `make_pweight_design(arr)`, but qug_test permanently
rejects ALL survey-aware kwargs (Phase 4.5 C0 deferral). Replaced with
qug-specific warning text that says the aliases are deprecated AND
that survey-aware QUG remains unsupported, pointing users to
`did_had_pretest_workflow(..., survey_design=...)` for the survey-aware
linearity family instead.

R10 P3 #2 (weights= parity tests on data-in wrappers): the previous
round added survey= parity for joint_pretrends_test,
joint_homogeneity_test, and did_had_pretest_workflow(aggregate='overall')
but left the weights= rebinding paths warning-only with no numerical
parity lock. Added 3 new tests:
test_legacy_alias_parity_weights (joint_pretrends_test +
joint_homogeneity_test) and test_legacy_alias_parity_weights_overall
(workflow). Each asserts `weights=np.ones(n)` ≡
`survey_design=SurveyDesign(weights="w")` (uniform 1.0 column) on
identical-numerical-output, locking the rebinding contract.

561 tests pass (was 558 + 3 new R10 P3 parity tests).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: igerber

diff_diff/had_pretests.py

@@ -1307,13 +1307,37 @@ def qug_test(
         )
 
     # Soft deprecation: route legacy survey=/weights= aliases through
-    # survey_design= for the gated NotImplementedError below.
+    # survey_design= for the gated NotImplementedError below. PR #376 R10
+    # P3: qug_test-specific deprecation messages — the shared
+    # HAD_DEPRECATION_MSG_*_KWARG_ARRAY_IN strings tell users to migrate to
+    # `survey_design=` / `make_pweight_design(...)`, but qug_test
+    # permanently rejects ALL survey-aware kwargs (Phase 4.5 C0 deferral).
+    # Use qug-specific warning text that says the aliases are deprecated
+    # but survey-aware QUG remains unsupported, and points users to
+    # unweighted `qug_test()` or `did_had_pretest_workflow(...,
+    # survey_design=...)` for the survey-aware linearity family.
     if survey is not None:
-        warnings.warn(HAD_DEPRECATION_MSG_SURVEY_KWARG, DeprecationWarning, stacklevel=2)
+        warnings.warn(
+            "`survey=` is deprecated on qug_test (will be removed in the "
+            "next minor release). Note that qug_test does NOT support "
+            "survey-aware inputs at all (Phase 4.5 C0 permanent deferral; "
+            "see the NotImplementedError below). For survey-aware HAD "
+            "pretesting, use `did_had_pretest_workflow(..., "
+            "survey_design=...)` (the workflow skips the QUG step under "
+            "survey/weights and runs the linearity family).",
+            DeprecationWarning,
+            stacklevel=2,
+        )
         survey_design = survey
     elif weights is not None:
         warnings.warn(
-            HAD_DEPRECATION_MSG_WEIGHTS_KWARG_ARRAY_IN,
+            "`weights=` is deprecated on qug_test (will be removed in the "
+            "next minor release). Note that qug_test does NOT support "
+            "weighted/survey inputs at all (Phase 4.5 C0 permanent deferral; "
+            "see the NotImplementedError below). For survey-aware HAD "
+            "pretesting, use `did_had_pretest_workflow(..., "
+            "survey_design=...)` (the workflow skips the QUG step under "
+            "survey/weights and runs the linearity family).",
             DeprecationWarning,
             stacklevel=2,
         )

tests/test_had_dual_knob_deprecation.py

@@ -640,6 +640,41 @@ def test_legacy_alias_parity_survey(self, event_study_panel):
         assert r_legacy.cvm_stat_joint == r_new.cvm_stat_joint
         assert r_legacy.p_value == r_new.p_value
 
+    def test_legacy_alias_parity_weights(self, event_study_panel):
+        """PR #376 R10 P3: deprecated `weights=np.ones(n)` ≡ canonical
+        `survey_design=SurveyDesign(weights="w")` (uniform 1.0 column) on
+        joint_pretrends_test."""
+        df = event_study_panel
+        n = len(df)
+        with warnings.catch_warnings():
+            warnings.simplefilter("ignore", DeprecationWarning)
+            r_legacy = joint_pretrends_test(
+                df,
+                "y",
+                "d",
+                "time",
+                "unit",
+                pre_periods=[0],
+                base_period=1,
+                weights=np.ones(n),
+                n_bootstrap=199,
+                seed=0,
+            )
+        r_new = joint_pretrends_test(
+            df,
+            "y",
+            "d",
+            "time",
+            "unit",
+            pre_periods=[0],
+            base_period=1,
+            survey_design=SurveyDesign(weights="w"),
+            n_bootstrap=199,
+            seed=0,
+        )
+        assert r_legacy.cvm_stat_joint == r_new.cvm_stat_joint
+        assert r_legacy.p_value == r_new.p_value
+
 
 class TestJointHomogeneityTestDeprecation:
     def test_survey_design_kwarg_smoke(self, event_study_panel):
@@ -725,6 +760,41 @@ def test_legacy_alias_parity_survey(self, event_study_panel):
         assert r_legacy.cvm_stat_joint == r_new.cvm_stat_joint
         assert r_legacy.p_value == r_new.p_value
 
+    def test_legacy_alias_parity_weights(self, event_study_panel):
+        """PR #376 R10 P3: deprecated `weights=np.ones(n)` ≡ canonical
+        `survey_design=SurveyDesign(weights="w")` on
+        joint_homogeneity_test."""
+        df = event_study_panel
+        n = len(df)
+        with warnings.catch_warnings():
+            warnings.simplefilter("ignore", DeprecationWarning)
+            r_legacy = joint_homogeneity_test(
+                df,
+                "y",
+                "d",
+                "time",
+                "unit",
+                post_periods=[2, 3],
+                base_period=1,
+                weights=np.ones(n),
+                n_bootstrap=199,
+                seed=0,
+            )
+        r_new = joint_homogeneity_test(
+            df,
+            "y",
+            "d",
+            "time",
+            "unit",
+            post_periods=[2, 3],
+            base_period=1,
+            survey_design=SurveyDesign(weights="w"),
+            n_bootstrap=199,
+            seed=0,
+        )
+        assert r_legacy.cvm_stat_joint == r_new.cvm_stat_joint
+        assert r_legacy.p_value == r_new.p_value
+
 
 class TestHADFitDeprecation:
     def test_survey_design_kwarg_smoke(self, two_period_panel):
@@ -967,6 +1037,40 @@ def test_legacy_alias_parity_survey_overall(self, two_period_panel):
         assert r_legacy.stute.p_value == r_new.stute.p_value
         assert r_legacy.yatchew.t_stat_hr == r_new.yatchew.t_stat_hr
 
+    def test_legacy_alias_parity_weights_overall(self, two_period_panel):
+        """PR #376 R10 P3: deprecated `weights=np.ones(n)` ≡ canonical
+        `survey_design=SurveyDesign(weights="w")` on
+        did_had_pretest_workflow(aggregate='overall'). Closes the data-in
+        rebinding-parity gap on the weights= shortcut path."""
+        df = two_period_panel
+        n = len(df)
+        with warnings.catch_warnings():
+            warnings.simplefilter("ignore", UserWarning)
+            warnings.simplefilter("ignore", DeprecationWarning)
+            r_legacy = did_had_pretest_workflow(
+                df,
+                "y",
+                "d",
+                "time",
+                "unit",
+                weights=np.ones(n),
+                n_bootstrap=199,
+                seed=0,
+            )
+            r_new = did_had_pretest_workflow(
+                df,
+                "y",
+                "d",
+                "time",
+                "unit",
+                survey_design=SurveyDesign(weights="w"),
+                n_bootstrap=199,
+                seed=0,
+            )
+        assert r_legacy.stute.cvm_stat == r_new.stute.cvm_stat
+        assert r_legacy.stute.p_value == r_new.stute.p_value
+        assert r_legacy.yatchew.t_stat_hr == r_new.yatchew.t_stat_hr
+
 
 # =============================================================================
 # 3. PR #376 R2 P1: extended dispatch-matrix coverage on the new front door