Commit 2f95353
committed
Strengthen R0/R1 regression tests per CI feedback
CI AI review on #435:
- P2: exp_p / exp_ci returned from safe_inference() were unused (F841).
Extended event-study test to assert p_value and conf_int match
safe_inference output too, not just t_stat. The safe_inference
contract is joint NaN propagation across the full inference tuple,
so testing all three jointly is the right invariant.
- P3: placebo test only checked 'at least one finite entry', so a
silent path-drop on the replicate-weight placebo branch could pass.
Added explicit assertions that both (0,1,1,1) and (0,1,0,0) are
present in res.path_placebo_event_study before checking SE/inference.1 parent 44c4f69 commit 2f95353
1 file changed
Lines changed: 17 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9998 | 9998 | | |
9999 | 9999 | | |
10000 | 10000 | | |
10001 | | - | |
| 10001 | + | |
10002 | 10002 | | |
10003 | 10003 | | |
10004 | | - | |
10005 | | - | |
10006 | | - | |
| 10004 | + | |
| 10005 | + | |
| 10006 | + | |
| 10007 | + | |
| 10008 | + | |
| 10009 | + | |
| 10010 | + | |
| 10011 | + | |
| 10012 | + | |
| 10013 | + | |
| 10014 | + | |
10007 | 10015 | | |
10008 | 10016 | | |
10009 | 10017 | | |
| |||
10052 | 10060 | | |
10053 | 10061 | | |
10054 | 10062 | | |
10055 | | - | |
| 10063 | + | |
| 10064 | + | |
| 10065 | + | |
10056 | 10066 | | |
| 10067 | + | |
| 10068 | + | |
10057 | 10069 | | |
10058 | 10070 | | |
10059 | 10071 | | |
| |||
0 commit comments