Commit 33e9c67
Fix CI review R5: persist pre/post_periods_used on HonestDiDResults
- Add pre_periods_used and post_periods_used fields to HonestDiDResults
so the retained horizon set is always available on the results object
- HonestDiD.fit() populates both fields from the extracted period lists
- Summary renders retained horizons below the target label
- Add test_honest_did_retains_period_metadata asserting fields populated
and summary shows "Post horizons used:"
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 419d872 commit 33e9c67
3 files changed
Lines changed: 34 additions & 0 deletions
File tree
- diff_diff
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
988 | 988 | | |
989 | 989 | | |
990 | 990 | | |
| 991 | + | |
| 992 | + | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
| 1001 | + | |
| 1002 | + | |
991 | 1003 | | |
992 | 1004 | | |
993 | 1005 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
192 | 192 | | |
193 | 193 | | |
194 | 194 | | |
| 195 | + | |
| 196 | + | |
195 | 197 | | |
196 | 198 | | |
197 | 199 | | |
| |||
2330 | 2332 | | |
2331 | 2333 | | |
2332 | 2334 | | |
| 2335 | + | |
| 2336 | + | |
2333 | 2337 | | |
2334 | 2338 | | |
2335 | 2339 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3404 | 3404 | | |
3405 | 3405 | | |
3406 | 3406 | | |
| 3407 | + | |
| 3408 | + | |
| 3409 | + | |
| 3410 | + | |
| 3411 | + | |
| 3412 | + | |
| 3413 | + | |
| 3414 | + | |
| 3415 | + | |
| 3416 | + | |
| 3417 | + | |
| 3418 | + | |
| 3419 | + | |
| 3420 | + | |
| 3421 | + | |
| 3422 | + | |
| 3423 | + | |
| 3424 | + | |
3407 | 3425 | | |
3408 | 3426 | | |
3409 | 3427 | | |
| |||
0 commit comments