Commit 345f65c
Address fourth round of CI review findings on PR #318
P0 fix:
* **``inference_method == 'wild_bootstrap'`` was not detected as
bootstrap-like.** My prior bootstrap check caught ``'bootstrap'`` and
``variance_method in {bootstrap, jackknife, placebo}`` plus an
attached ``bootstrap_distribution``, but ``DifferenceInDifferences(
inference='wild_bootstrap')`` returns ``inference_method='wild_bootstrap'``
and a percentile-bootstrap CI without necessarily attaching the raw
distribution. The override path silently replaced that CI with a
normal-approximation one. Fixed by matching both
``'bootstrap'`` and ``'wild_bootstrap'``; the preserved-CI caveat
now calls out "wild cluster bootstrap" specifically when that path
triggered. Regression: ``TestWildBootstrapAlphaOverride``.
P1 fix:
* **``_describe_assumption()`` emitted generic DiD PT text for
ContinuousDiD / TripleDifference / StaggeredTripleDiff**, all of
which have identifying logic different from ordinary group-time PT
per ``docs/methodology/REGISTRY.md``. Replaced the generic fallback
with source-backed branches:
- ``ContinuousDiDResults``: two-level parallel trends (PT vs Strong
PT) per Callaway, Goodman-Bacon & Sant'Anna (2024), with explicit
mention of ATT(d|d), ATT(d), ACRT identification sets.
- ``TripleDifferenceResults`` / ``StaggeredTripleDiffResults``:
triple-difference cancellation across the 2x2x2 cells per
Ortiz-Villavicencio & Sant'Anna (2025); notes that identification
is weaker than ordinary DiD PT and depends on additive
separability across the three dimensions.
The ``parallel_trends_variant`` schema field gains two new values:
``"dose_pt_or_strong_pt"`` and ``"triple_difference_cancellation"``.
Direct regressions in ``TestAssumptionBlockSourceFaithful`` assert
registry-backed language (attribution phrases + method names) is
present and generic group-time PT text is absent.
150 targeted tests pass; black, ruff, mypy clean on the new modules.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 959f84e commit 345f65c
2 files changed
Lines changed: 176 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
364 | 364 | | |
365 | 365 | | |
366 | 366 | | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
367 | 370 | | |
368 | | - | |
| 371 | + | |
369 | 372 | | |
370 | 373 | | |
371 | 374 | | |
| |||
375 | 378 | | |
376 | 379 | | |
377 | 380 | | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
378 | 387 | | |
379 | 388 | | |
380 | | - | |
381 | | - | |
| 389 | + | |
382 | 390 | | |
383 | 391 | | |
384 | 392 | | |
| |||
611 | 619 | | |
612 | 620 | | |
613 | 621 | | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
614 | 666 | | |
615 | 667 | | |
616 | 668 | | |
| |||
620 | 672 | | |
621 | 673 | | |
622 | 674 | | |
623 | | - | |
624 | 675 | | |
625 | 676 | | |
626 | 677 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
606 | 606 | | |
607 | 607 | | |
608 | 608 | | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
609 | 730 | | |
610 | 731 | | |
611 | 732 | | |
| |||
0 commit comments