Skip to content

Commit 34f6c22

Browse files
authored
Merge pull request #195 from igerber/feature/trop-global-method-1w-masking
Add (1-W) weight masking to TROP global method
2 parents 448d3cb + 574585f commit 34f6c22

9 files changed

Lines changed: 1205 additions & 292 deletions

File tree

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,3 +87,6 @@ trop_avg_ref/
8787

8888
# Academic papers (local only, not for distribution)
8989
papers/
90+
91+
# Local analysis notebooks (not committed)
92+
analysis/

CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,19 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [Unreleased]
9+
10+
### Changed
11+
- **BREAKING: TROP nuclear norm solver step size fix** — The proximal gradient
12+
threshold for the L matrix (both `method="global"` and `method="twostep"` with
13+
finite `lambda_nn`) was over-shrinking singular values by a factor of 2. The
14+
soft-thresholding threshold was λ_nn/max(δ) when the correct value is
15+
λ_nn/(2·max(δ)), derived from the Lipschitz constant L_f=2·max(δ) of the
16+
quadratic gradient. This fix produces higher-rank L matrices and closer
17+
agreement with exact convex optimization solutions. Users with finite
18+
`lambda_nn` will observe different ATT estimates. Added FISTA/Nesterov
19+
acceleration to the twostep inner solver for faster L convergence.
20+
821
## [2.6.1] - 2026-03-08
922

1023
### Added

0 commit comments

Comments
 (0)