Commit 370915e
Address PR #366 CI review round 2 (2 P3): align ROADMAP wording with corrected scope; cover new exports in import-surface test
P3 #1 (ROADMAP wording drift):
ROADMAP.md still said the new fields "gate WooldridgeDiD QMLE /
ContinuousDiD prerequisites pre-fit" and mentioned "time-invariance",
which contradicted the round-1 corrections to TreatmentDoseShape's
docstring + autonomous guide §2 + §5.2. Reworded to match: the new
fields add descriptive distributional context only;
`outcome_shape.is_count_like` informs (not gates) the WooldridgeDiD
QMLE judgment, and the authoritative ContinuousDiD pre-fit gates
remain `has_never_treated`, `treatment_varies_within_unit`, and
`is_balanced`. "Time-invariance" wording removed (the field was
dropped in round 1).
P3 #2 (import-surface test coverage):
`test_top_level_import_surface()` previously only verified
`profile_panel`, `PanelProfile`, `Alert`. Extended to also cover the
two new public exports `OutcomeShape` and `TreatmentDoseShape`,
asserting both their importability and their presence in
`diff_diff.__all__`.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent cc91a7d commit 370915e
2 files changed
Lines changed: 13 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
141 | | - | |
| 141 | + | |
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
402 | 402 | | |
403 | 403 | | |
404 | 404 | | |
405 | | - | |
406 | | - | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
407 | 408 | | |
408 | 409 | | |
409 | 410 | | |
410 | 411 | | |
411 | 412 | | |
412 | | - | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
413 | 422 | | |
414 | 423 | | |
415 | 424 | | |
| |||
0 commit comments