Commit 44f2632
Address PR #372 R4 review (1 P2, 1 P3) + rebase onto main
(Branch rebased onto origin/main first - 32 landed commits replayed cleanly,
zero file overlap with the docs-refresh changeset.)
P2 - llms-practitioner.txt Step 6 inconsistent on dCDH HonestDiD support
- The high-level workflow surfaces (README, bundled llms.txt) and the
practitioner guide's estimator tree (L177-180) all advertise
compute_honest_did(results) on MultiPeriodDiD / CallawaySantAnna /
ChaisemartinDHaultfoeuille, but Step 6 still said "MultiPeriodDiD and
CallawaySantAnna only".
- Update Step 6 to add dCDH with the registry caveats: requires L_max >= 1,
bounds use placebo estimates as pre-period coefficients (not standard
event-study pre-treatment coefficients), uses diagonal variance (no full
VCV available), emits UserWarning. Cross-references the REGISTRY.md
"Note (HonestDiD integration)" entry under ChaisemartinDHaultfoeuille
for the full caveat list.
P3 - docs/doc-deps.yaml unsectioned llms.txt entries
- Add `section: "Estimators"` to the 5 remaining unsectioned
`diff_diff/guides/llms.txt` mappings (estimators.py, staggered.py,
chaisemartin_dhaultfoeuille.py, results.py, __init__.py). Now every
llms.txt mapping in doc-deps.yaml carries a section label, matching the
new "first-class documentation surface" contract.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent fe120eb commit 44f2632
2 files changed
Lines changed: 17 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
293 | 293 | | |
294 | 294 | | |
295 | 295 | | |
296 | | - | |
| 296 | + | |
297 | 297 | | |
298 | | - | |
299 | | - | |
300 | | - | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
301 | 309 | | |
302 | 310 | | |
303 | 311 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| 105 | + | |
105 | 106 | | |
106 | 107 | | |
107 | 108 | | |
| |||
145 | 146 | | |
146 | 147 | | |
147 | 148 | | |
| 149 | + | |
148 | 150 | | |
149 | 151 | | |
150 | 152 | | |
| |||
314 | 316 | | |
315 | 317 | | |
316 | 318 | | |
| 319 | + | |
317 | 320 | | |
318 | 321 | | |
319 | 322 | | |
| |||
690 | 693 | | |
691 | 694 | | |
692 | 695 | | |
| 696 | + | |
693 | 697 | | |
694 | 698 | | |
695 | 699 | | |
| |||
758 | 762 | | |
759 | 763 | | |
760 | 764 | | |
| 765 | + | |
761 | 766 | | |
762 | 767 | | |
763 | 768 | | |
| |||
0 commit comments