Commit 4e829a2
Address PR #447 R1 review (2 P2, 1 self-audit)
P2 — SE-consistency rewrite misstated the public API
The rewrite listed cr1, cr2, bootstrap as vcov_type values. The actual
validated set in linalg.py::_VALID_VCOV_TYPES is
{"classical","hc1","hc2","hc2_bm","conley"}; cluster-robust variance is
obtained via cluster= alongside the heteroscedasticity kind (hc1+cluster
⇒ CR1, hc2_bm+cluster ⇒ CR2 Bell-McCaffrey), and wild cluster bootstrap
is a separate inference="wild_bootstrap" path on the same estimator.
Rewrote the SE Consistency paragraph to match the actual API.
P2 — Large Module Files table omitted 8 modules already ≥1000 lines
The refreshed inventory in section 24-56 missed: _nprobust_port.py
(1412), practitioner.py (1402), trop_global.py (1350), trop_local.py
(1339), local_linear.py (1332), wooldridge.py (1305),
chaisemartin_dhaultfoeuille_bootstrap.py (1175), stacked_did.py (1050).
Mechanically regenerated from wc -l diff_diff/*.py >= 1000; all 35
current ≥1000-line modules now listed (verified via comm).
Self-audit fix
linalg.py Action cell read "Consider splitting (vcov surfaces) — unified
backend, splitting would hurt cohesion" — self-contradictory. Reworded to
"Consider splitting only if cohesion can be preserved" so the threshold
rule and the cohesion constraint can both be honored.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent fe3ab98 commit 4e829a2
1 file changed
Lines changed: 10 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
54 | 61 | | |
55 | 62 | | |
| 63 | + | |
56 | 64 | | |
57 | 65 | | |
58 | 66 | | |
| |||
211 | 219 | | |
212 | 220 | | |
213 | 221 | | |
214 | | - | |
| 222 | + | |
215 | 223 | | |
216 | 224 | | |
217 | 225 | | |
| |||
0 commit comments